Re: [ovs-dev] [PATCH ovn v4 1/2] northd: Make `vxlan_mode` a global variable.

2024-05-02 Thread Vladislav Odintsov
Hi Ihar, thanks for your review! > On 2 May 2024, at 18:11, Ihar Hrachyshka wrote: > > On Thu, May 2, 2024 at 5:51 AM Vladislav Odintsov > wrote: > >> This simplifies code and subsequent commit to explicitely disable vxlan >> > > I personally find it debatable

Re: [ovs-dev] [PATCH ovn v4 1/2] northd: Make `vxlan_mode` a global variable.

2024-05-02 Thread Ihar Hrachyshka
On Thu, May 2, 2024 at 5:51 AM Vladislav Odintsov wrote: > This simplifies code and subsequent commit to explicitely disable vxlan > I personally find it debatable that moving from explicit dependency through a function argument to implicit dependency through a global variable is a

[ovs-dev] [PATCH ovn v4 1/2] northd: Make `vxlan_mode` a global variable.

2024-05-02 Thread Vladislav Odintsov
This simplifies code and subsequent commit to explicitely disable vxlan mode is based on these changes. Also `vxlan mode` term is introduced in ovn-architecture man page. Signed-off-by: Vladislav Odintsov --- northd/en-global-config.c | 4 +- northd/northd.c | 94