Re: [ovs-dev] [PATCH ovn v5 03/16] northd: Move router ports SB PB options sync to sync_to_sb_pb node.

2024-01-29 Thread Numan Siddique
On Fri, Jan 26, 2024 at 4:30 AM Dumitru Ceara wrote: > > On 1/25/24 22:01, Numan Siddique wrote: > > On Thu, Jan 25, 2024, 3:29 PM Dumitru Ceara wrote: > > > >> On 1/25/24 17:46, Numan Siddique wrote: > >>> On Tue, Jan 16, 2024 at 6:15 AM Dumitru Ceara wrote: > > On 1/11/24 16:28, num.

Re: [ovs-dev] [PATCH ovn v5 03/16] northd: Move router ports SB PB options sync to sync_to_sb_pb node.

2024-01-26 Thread Dumitru Ceara
On 1/25/24 22:01, Numan Siddique wrote: > On Thu, Jan 25, 2024, 3:29 PM Dumitru Ceara wrote: > >> On 1/25/24 17:46, Numan Siddique wrote: >>> On Tue, Jan 16, 2024 at 6:15 AM Dumitru Ceara wrote: On 1/11/24 16:28, num...@ovn.org wrote: > From: Numan Siddique > > It also mov

Re: [ovs-dev] [PATCH ovn v5 03/16] northd: Move router ports SB PB options sync to sync_to_sb_pb node.

2024-01-25 Thread Numan Siddique
On Thu, Jan 25, 2024, 3:29 PM Dumitru Ceara wrote: > On 1/25/24 17:46, Numan Siddique wrote: > > On Tue, Jan 16, 2024 at 6:15 AM Dumitru Ceara wrote: > >> > >> On 1/11/24 16:28, num...@ovn.org wrote: > >>> From: Numan Siddique > >>> > >>> It also moves the logical router port IPv6 prefix delega

Re: [ovs-dev] [PATCH ovn v5 03/16] northd: Move router ports SB PB options sync to sync_to_sb_pb node.

2024-01-25 Thread Dumitru Ceara
On 1/25/24 17:46, Numan Siddique wrote: > On Tue, Jan 16, 2024 at 6:15 AM Dumitru Ceara wrote: >> >> On 1/11/24 16:28, num...@ovn.org wrote: >>> From: Numan Siddique >>> >>> It also moves the logical router port IPv6 prefix delegation >>> updates to "sync-from-sb" engine node. >>> >>> With these

Re: [ovs-dev] [PATCH ovn v5 03/16] northd: Move router ports SB PB options sync to sync_to_sb_pb node.

2024-01-25 Thread Numan Siddique
On Tue, Jan 16, 2024 at 6:15 AM Dumitru Ceara wrote: > > On 1/11/24 16:28, num...@ovn.org wrote: > > From: Numan Siddique > > > > It also moves the logical router port IPv6 prefix delegation > > updates to "sync-from-sb" engine node. > > > > With these changes, northd engine node doesn't need to

Re: [ovs-dev] [PATCH ovn v5 03/16] northd: Move router ports SB PB options sync to sync_to_sb_pb node.

2024-01-21 Thread Han Zhou
On Thu, Jan 11, 2024 at 7:29 AM wrote: > > From: Numan Siddique > > It also moves the logical router port IPv6 prefix delegation > updates to "sync-from-sb" engine node. > > With these changes, northd engine node doesn't need to do much > for SB Port binding changes other than updating 'op->sb'.

Re: [ovs-dev] [PATCH ovn v5 03/16] northd: Move router ports SB PB options sync to sync_to_sb_pb node.

2024-01-16 Thread Dumitru Ceara
On 1/11/24 16:28, num...@ovn.org wrote: > From: Numan Siddique > > It also moves the logical router port IPv6 prefix delegation > updates to "sync-from-sb" engine node. > > With these changes, northd engine node doesn't need to do much > for SB Port binding changes other than updating 'op->sb'.

Re: [ovs-dev] [PATCH ovn v5 03/16] northd: Move router ports SB PB options sync to sync_to_sb_pb node.

2024-01-11 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Comment with 'xxx' marker #178 FILE: northd/northd.c:4881: /* XXX Why ca

[ovs-dev] [PATCH ovn v5 03/16] northd: Move router ports SB PB options sync to sync_to_sb_pb node.

2024-01-11 Thread numans
From: Numan Siddique It also moves the logical router port IPv6 prefix delegation updates to "sync-from-sb" engine node. With these changes, northd engine node doesn't need to do much for SB Port binding changes other than updating 'op->sb'. And there is no need to fall back to recompute. Prio