4 08:51, Vladislav Odintsov wrote:
>>>> Hi Mark,
>>>> Thanks for the review!
>>>> Please, see below.
>>>> regards,
>>>> Vladislav Odintsov
>>>> -----Original Message-
>>>> From: Mark Michelson
>>>
n 6/5/24 08:51, Vladislav Odintsov wrote:
> >> Hi Mark,
> >> Thanks for the review!
> >> Please, see below.
> >> regards,
> >> Vladislav Odintsov
> >> -Original Message-
> >> From: Mark Michelson
> >> Date: Tuesda
Message-
>> From: Mark Michelson
>> Date: Tuesday, 4 June 2024 at 03:45
>> To: Vladislav Odintsov ,
>> Subject: Re: [ovs-dev] [PATCH ovn v5 1/2] northd: Make `vxlan_mode` a global
>> variable.
>> Hi Vladislav,
>> Generally speaking
On 6/5/24 08:51, Vladislav Odintsov wrote:
Hi Mark,
Thanks for the review!
Please, see below.
regards,
Vladislav Odintsov
-Original Message-
From: Mark Michelson
Date: Tuesday, 4 June 2024 at 03:45
To: Vladislav Odintsov ,
Subject: Re: [ovs-dev] [PATCH ovn v5 1/2] northd: Make
Hi Mark,
Thanks for the review!
Please, see below.
regards,
Vladislav Odintsov
-Original Message-
From: Mark Michelson
Date: Tuesday, 4 June 2024 at 03:45
To: Vladislav Odintsov ,
Subject: Re: [ovs-dev] [PATCH ovn v5 1/2] northd: Make `vxlan_mode` a global
variable.
Hi
Hi Vladislav,
Generally speaking, I agree with this change. However, I think that
setting a global variable from an incremental processing engine node
runner feels wrong.
I think that instead, the "vxlan_mode" variable you have introduced
should be a field on struct ed_type_global_config.
This simplifies code and subsequent commit to explicitely disable VXLAN
mode is based on these changes.
Also "VXLAN mode" term is introduced in ovn-architecture man page.
Signed-off-by: Vladislav Odintsov
---
northd/en-global-config.c | 4 +-
northd/northd.c | 85
