Re: [ovs-dev] [PATCH v1 3/3 ovn] NAT: Parsing port_range options in ct_*nat actions

2020-04-01 Thread Ankur Sharma
Hi Mark, Thanks a lot for review. Addressed all the comments. Please take a look at V2. Regards, Ankur -Original Message- From: dev On Behalf Of Mark Michelson Sent: Monday, March 30, 2020 12:21 PM To: svc.mail.git ; ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v1 3/3 ovn] NAT

Re: [ovs-dev] [PATCH v1 3/3 ovn] NAT: Parsing port_range options in ct_*nat actions

2020-03-30 Thread Mark Michelson
This and patch 2 should be combined into one patch. Patch 2 in isolation adds invalid ct_snat and ct_dnat commands since the code for encoding them is not added until patch 3. See below for additional in-line comments. On 3/27/20 7:18 PM, Ankur Sharma wrote: From: Ankur Sharma Changes to

[ovs-dev] [PATCH v1 3/3 ovn] NAT: Parsing port_range options in ct_*nat actions

2020-03-27 Thread Ankur Sharma
From: Ankur Sharma Changes to parse the logical flow, which specifies port_range for ct_nat action. Example logical flow: ct_snat(10.15.24.135,1-3) Signed-off-by: Ankur Sharma --- include/ovn/actions.h | 7 +++ include/ovn/lex.h | 1 + lib/actions.c | 39