Re: [ovs-dev] [PATCH v12] netdev-dpdk: Add custom rx-steering configuration.

2023-06-30 Thread Ilya Maximets
On 6/30/23 10:00, Robin Jarry wrote: > Hi Ilya, > > Ilya Maximets, Jun 29, 2023 at 23:57: >>> +if (flags && ovsrcu_get(void *, >hw_info.offload_data)) { >> >> We probbaly shouldn't use the offload_data outside of netdev-offload >> modules. Simply checking netdev_is_flow_api_enabled() should

Re: [ovs-dev] [PATCH v12] netdev-dpdk: Add custom rx-steering configuration.

2023-06-30 Thread Robin Jarry
Hi Ilya, Ilya Maximets, Jun 29, 2023 at 23:57: > > +if (flags && ovsrcu_get(void *, >hw_info.offload_data)) { > > We probbaly shouldn't use the offload_data outside of netdev-offload > modules. Simply checking netdev_is_flow_api_enabled() should be > enough. Since both features require

Re: [ovs-dev] [PATCH v12] netdev-dpdk: Add custom rx-steering configuration.

2023-06-29 Thread Ilya Maximets
On 6/21/23 21:24, Robin Jarry wrote: > Some control protocols are used to maintain link status between > forwarding engines (e.g. LACP). When the system is not sized properly, > the PMD threads may not be able to process all incoming traffic from the > configured Rx queues. When a signaling packet

Re: [ovs-dev] [PATCH v12] netdev-dpdk: Add custom rx-steering configuration.

2023-06-22 Thread Kevin Traynor
On 22/06/2023 14:06, Kevin Traynor wrote: On 21/06/2023 20:24, Robin Jarry wrote: Some control protocols are used to maintain link status between forwarding engines (e.g. LACP). When the system is not sized properly, the PMD threads may not be able to process all incoming traffic from the

Re: [ovs-dev] [PATCH v12] netdev-dpdk: Add custom rx-steering configuration.

2023-06-22 Thread Robin Jarry
Hi Kevin, Kevin Traynor, Jun 22, 2023 at 15:06: > Hi Robin, > > As discussed offline, the issue is fixed in v12. In the case where > offload has failed on device A, and device B triggers set_config the > set_config for device B will see that device B has the correct number of > queues

Re: [ovs-dev] [PATCH v12] netdev-dpdk: Add custom rx-steering configuration.

2023-06-22 Thread Kevin Traynor
On 21/06/2023 20:24, Robin Jarry wrote: Some control protocols are used to maintain link status between forwarding engines (e.g. LACP). When the system is not sized properly, the PMD threads may not be able to process all incoming traffic from the configured Rx queues. When a signaling packet of

[ovs-dev] [PATCH v12] netdev-dpdk: Add custom rx-steering configuration.

2023-06-21 Thread Robin Jarry
Some control protocols are used to maintain link status between forwarding engines (e.g. LACP). When the system is not sized properly, the PMD threads may not be able to process all incoming traffic from the configured Rx queues. When a signaling packet of such protocols is dropped, it can cause