Re: [ovs-dev] [PATCH v12 0/1] Balance-tcp bond mode optimization

2020-04-06 Thread Vishal Deep Ajmera via dev
> > Hi Matteo, > > > > Thanks for the patch. But I fail to understand why there is a memory leak. > > In fact when I tested in my setup, the test ran without any leak. > > The main part is: > '_REFILL_' loop removes packets from the original batch and > dp_execute_output_action() > doesn't free

Re: [ovs-dev] [PATCH v12 0/1] Balance-tcp bond mode optimization

2020-04-06 Thread Vishal Deep Ajmera via dev
Hi Matteo, Thanks for the patch. But I fail to understand why there is a memory leak. In fact when I tested in my setup, the test ran without any leak. The functions dp_execute_lb_output_action and dp_execute_output_action, both return 'false' if current batch is non-empty. case

Re: [ovs-dev] [PATCH v12 0/1] Balance-tcp bond mode optimization

2020-04-06 Thread Ilya Maximets
On 4/6/20 3:03 PM, Vishal Deep Ajmera wrote: > Hi Matteo, > > Thanks for the patch. But I fail to understand why there is a memory leak. > In fact when I tested in my setup, the test ran without any leak. The main part is: '_REFILL_' loop removes packets from the original batch and

Re: [ovs-dev] [PATCH v12 0/1] Balance-tcp bond mode optimization

2020-03-31 Thread Ilya Maximets
On 3/31/20 12:28 PM, Matteo Croce wrote: > On Wed, Mar 11, 2020 at 3:26 PM Vishal Deep Ajmera > wrote: >> >> v11->v12: >> Addressed most of comments from Ilya and Eelco. >> https://mail.openvswitch.org/pipermail/ovs-dev/2020-February/367832.html >>

Re: [ovs-dev] [PATCH v12 0/1] Balance-tcp bond mode optimization

2020-03-31 Thread Matteo Croce
On Wed, Mar 11, 2020 at 3:26 PM Vishal Deep Ajmera wrote: > > v11->v12: > Addressed most of comments from Ilya and Eelco. > https://mail.openvswitch.org/pipermail/ovs-dev/2020-February/367832.html > https://mail.openvswitch.org/pipermail/ovs-dev/2020-February/367842.html > Rebased to OVS

[ovs-dev] [PATCH v12 0/1] Balance-tcp bond mode optimization

2020-03-11 Thread Vishal Deep Ajmera via dev
v11->v12: Addressed most of comments from Ilya and Eelco. https://mail.openvswitch.org/pipermail/ovs-dev/2020-February/367832.html https://mail.openvswitch.org/pipermail/ovs-dev/2020-February/367842.html Rebased to OVS master. v10->v11: Addressed Ben and Ilya's comments.