Re: [ovs-dev] [PATCH v12 1/8] lib: Add non-null assertions to some return values of `dp_packet_data`

2023-08-03 Thread James R T
On Tue, Jul 11, 2023 at 5:50 PM Eelco Chaudron wrote: > > This patch looks good, however, it needs a re-work due to changes to tunnel > checksum handling. > > //Eelco > Apologies for the late reply. I have been busy with other work. I will fix the merge conflict in the next patch version. Best

Re: [ovs-dev] [PATCH v12 1/8] lib: Add non-null assertions to some return values of `dp_packet_data`

2023-07-11 Thread Eelco Chaudron
On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote: > This commit adds some `ovs_assert()` checks to some return values of > `dp_packet_data()` to ensure that they are not NULL and to prevent > null-pointer dereferences, which might lead to unwanted crashes. We use > assertions since it

[ovs-dev] [PATCH v12 1/8] lib: Add non-null assertions to some return values of `dp_packet_data`

2023-06-13 Thread James Raphael Tiovalen
This commit adds some `ovs_assert()` checks to some return values of `dp_packet_data()` to ensure that they are not NULL and to prevent null-pointer dereferences, which might lead to unwanted crashes. We use assertions since it should be impossible for these calls to `dp_packet_data()` to return