Re: [ovs-dev] [PATCH v12 3/8] shash, simap, smap: Add assertions to `*_count` functions

2023-07-13 Thread Ilya Maximets
On 7/13/23 14:57, Eelco Chaudron wrote: > > > On 12 Jul 2023, at 0:34, Ilya Maximets wrote: > >> On 7/11/23 12:05, Eelco Chaudron wrote: >>> >>> >>> On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote: >>> This commit adds assertions in the functions `shash_count`, `simap_count`,

Re: [ovs-dev] [PATCH v12 3/8] shash, simap, smap: Add assertions to `*_count` functions

2023-07-13 Thread Eelco Chaudron
On 12 Jul 2023, at 0:34, Ilya Maximets wrote: > On 7/11/23 12:05, Eelco Chaudron wrote: >> >> >> On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote: >> >>> This commit adds assertions in the functions `shash_count`, >>> `simap_count`, and `smap_count` to ensure that the corresponding input

Re: [ovs-dev] [PATCH v12 3/8] shash, simap, smap: Add assertions to `*_count` functions

2023-07-11 Thread Ilya Maximets
On 7/11/23 12:05, Eelco Chaudron wrote: > > > On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote: > >> This commit adds assertions in the functions `shash_count`, >> `simap_count`, and `smap_count` to ensure that the corresponding input >> struct pointer is not NULL. >> >> This ensures that

Re: [ovs-dev] [PATCH v12 3/8] shash, simap, smap: Add assertions to `*_count` functions

2023-07-11 Thread Eelco Chaudron
On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote: > This commit adds assertions in the functions `shash_count`, > `simap_count`, and `smap_count` to ensure that the corresponding input > struct pointer is not NULL. > > This ensures that if the return values of `shash_sort`, `simap_sort`,

[ovs-dev] [PATCH v12 3/8] shash, simap, smap: Add assertions to `*_count` functions

2023-06-13 Thread James Raphael Tiovalen
This commit adds assertions in the functions `shash_count`, `simap_count`, and `smap_count` to ensure that the corresponding input struct pointer is not NULL. This ensures that if the return values of `shash_sort`, `simap_sort`, or `smap_sort` are NULL, then the following for loops would not