On Wed, Jul 12, 2023 at 6:49 AM Ilya Maximets wrote:
>
> These are not optional for a json parser and ovsdb_parser_finish()
> checks and fails if they do not exist. I don't think we should
> check them here. If we can't trust the parser code, we'll need to
> add this kind of checks in many
On Tue, Jul 11, 2023 at 7:40 PM Eelco Chaudron wrote:
>
> I think we should not assert, but do proper error handling here with a
> dpctl_error()
>
Sure, will do that in the next patch version.
>
> Same as above.
>
Got it.
>
> I think if we do a pop from an empty set, we should just return
On 7/11/23 13:40, Eelco Chaudron wrote:
>> diff --git a/ovsdb/jsonrpc-server.c b/ovsdb/jsonrpc-server.c
>> index 5361b3c76..a3ca48a7b 100644
>> --- a/ovsdb/jsonrpc-server.c
>> +++ b/ovsdb/jsonrpc-server.c
>> @@ -1131,6 +1131,8 @@ static void
>> ovsdb_jsonrpc_trigger_create(struct
On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote:
> This patch adds an assortment of `ovs_assert` statements to check for
> null pointers. We use assertions since it should be impossible for any
> of these pointers to be NULL.
>
> Signed-off-by: James Raphael Tiovalen
> Reviewed-by:
This patch adds an assortment of `ovs_assert` statements to check for
null pointers. We use assertions since it should be impossible for any
of these pointers to be NULL.
Signed-off-by: James Raphael Tiovalen
Reviewed-by: Simon Horman
---
lib/dp-packet.c| 1 +
lib/dpctl.c|
