Re: [ovs-dev] [PATCH v13 06/11] dpif-netdev: Add packet count and core id paramters for study

2021-07-15 Thread Amber, Kumar
Hi Flavio, > -Original Message- > From: Flavio Leitner > Sent: Thursday, July 15, 2021 8:28 PM > To: Eelco Chaudron > Cc: Amber, Kumar ; ovs-dev@openvswitch.org; > i.maxim...@ovn.org; Van Haaren, Harry ; > Ferriter, Cian ; Stokes, Ian > Subject: Re: [PATCH v13 06/11] dpif-netdev: Add pa

Re: [ovs-dev] [PATCH v13 06/11] dpif-netdev: Add packet count and core id paramters for study

2021-07-15 Thread Flavio Leitner
On Thu, Jul 15, 2021 at 04:15:13PM +0200, Eelco Chaudron wrote: > > Some minor changes in output, maybe they can be done during the commit? > > On 15 Jul 2021, at 14:42, kumar Amber wrote: > > > From: Kumar Amber > > > > This commit introduces additional command line paramter > > for mfex stud

Re: [ovs-dev] [PATCH v13 06/11] dpif-netdev: Add packet count and core id paramters for study

2021-07-15 Thread Stokes, Ian
Hi Eelco, These seem straight forward and I agree. Let us re-spin with these changes and I think this patch will be in a good to go state once these are addressed. Reverse Xmas tree order for variables. Standardize log errors to ‘miniflow extract’ (note lower case m and the word extract). Add ‘

Re: [ovs-dev] [PATCH v13 06/11] dpif-netdev: Add packet count and core id paramters for study

2021-07-15 Thread Eelco Chaudron
Some minor changes in output, maybe they can be done during the commit? On 15 Jul 2021, at 14:42, kumar Amber wrote: From: Kumar Amber This commit introduces additional command line paramter for mfex study function. If user provides additional packet out it is used in study to compare minimu

[ovs-dev] [PATCH v13 06/11] dpif-netdev: Add packet count and core id paramters for study

2021-07-15 Thread kumar Amber
From: Kumar Amber This commit introduces additional command line paramter for mfex study function. If user provides additional packet out it is used in study to compare minimum packets which must be processed else a default value is choosen. Also introduces a third paramter for choosing a particu