Re: [ovs-dev] [PATCH v15 4/4] userspace: Enable L4 checksum offloading by default.

2023-06-27 Thread Ilya Maximets
On 6/26/23 19:46, David Marchand wrote: > On Mon, Jun 26, 2023 at 4:05 PM David Marchand > wrote: >> >> On Mon, Jun 26, 2023 at 3:19 PM Ilya Maximets wrote: - if the UFO feature is "restored" in the master branch, OVS can't expose CSUM if the guest negotiated UFO. >>> >>> Yep. IIUC,

Re: [ovs-dev] [PATCH v15 4/4] userspace: Enable L4 checksum offloading by default.

2023-06-26 Thread David Marchand
On Mon, Jun 26, 2023 at 4:05 PM David Marchand wrote: > > On Mon, Jun 26, 2023 at 3:19 PM Ilya Maximets wrote: > > > - if the UFO feature is "restored" in the master branch, OVS can't > > > expose CSUM if the guest negotiated UFO. > > > > Yep. IIUC, that will require un-doing/re-wrking some of

Re: [ovs-dev] [PATCH v15 4/4] userspace: Enable L4 checksum offloading by default.

2023-06-26 Thread Ilya Maximets
On 6/26/23 16:05, David Marchand wrote: > On Mon, Jun 26, 2023 at 3:19 PM Ilya Maximets wrote: >>> - if the UFO feature is "restored" in the master branch, OVS can't >>> expose CSUM if the guest negotiated UFO. >> >> Yep. IIUC, that will require un-doing/re-wrking some of the changes Mike >> did

Re: [ovs-dev] [PATCH v15 4/4] userspace: Enable L4 checksum offloading by default.

2023-06-26 Thread David Marchand
On Mon, Jun 26, 2023 at 3:19 PM Ilya Maximets wrote: > > - if the UFO feature is "restored" in the master branch, OVS can't > > expose CSUM if the guest negotiated UFO. > > Yep. IIUC, that will require un-doing/re-wrking some of the changes Mike > did in order to restore ability to disable

Re: [ovs-dev] [PATCH v15 4/4] userspace: Enable L4 checksum offloading by default.

2023-06-26 Thread Ilya Maximets
On 6/26/23 11:37, David Marchand wrote: > On Fri, Jun 23, 2023 at 11:52 PM Ilya Maximets wrote: But we can't really do that from the OVS side, can we? DPDK will clear the bit even if we enable it... >>> >>> Hum, I did not test it yet, but I was thinking of calling >>>

Re: [ovs-dev] [PATCH v15 4/4] userspace: Enable L4 checksum offloading by default.

2023-06-26 Thread David Marchand
On Mon, Jun 26, 2023 at 11:37 AM David Marchand wrote: > > Currently possible configurations: > > > > 1. CSUM + TSO + ___ + ___ OVS 3.1 with userspace-tso=true > > 2. + TSO + ECN + ___ OVS 3.1 with userspace-tso=false > > 3. + ___ + ECN + UFO OVS 2.11 > > [snip] > I don't

Re: [ovs-dev] [PATCH v15 4/4] userspace: Enable L4 checksum offloading by default.

2023-06-26 Thread David Marchand
On Fri, Jun 23, 2023 at 11:52 PM Ilya Maximets wrote: > >> But we can't really do that from the OVS side, can we? > >> DPDK will clear the bit even if we enable it... > > > > Hum, I did not test it yet, but I was thinking of calling > > rte_vhost_driver_enable_features. > > Now that I look at the

Re: [ovs-dev] [PATCH v15 4/4] userspace: Enable L4 checksum offloading by default.

2023-06-26 Thread Maxime Coquelin
On 6/23/23 23:52, Ilya Maximets wrote: On 6/23/23 19:33, David Marchand wrote: On Fri, Jun 23, 2023 at 5:14 PM Ilya Maximets wrote: On 6/23/23 15:16, David Marchand wrote: On Wed, Jun 21, 2023 at 12:13 AM Ilya Maximets wrote: On 6/14/23 21:03, Mike Pattrick wrote: The netdev receiving

Re: [ovs-dev] [PATCH v15 4/4] userspace: Enable L4 checksum offloading by default.

2023-06-23 Thread Ilya Maximets
On 6/23/23 19:33, David Marchand wrote: > On Fri, Jun 23, 2023 at 5:14 PM Ilya Maximets wrote: >> On 6/23/23 15:16, David Marchand wrote: >>> On Wed, Jun 21, 2023 at 12:13 AM Ilya Maximets wrote: On 6/14/23 21:03, Mike Pattrick wrote: > The netdev receiving packets is supposed to

Re: [ovs-dev] [PATCH v15 4/4] userspace: Enable L4 checksum offloading by default.

2023-06-23 Thread David Marchand
On Fri, Jun 23, 2023 at 5:14 PM Ilya Maximets wrote: > On 6/23/23 15:16, David Marchand wrote: > > On Wed, Jun 21, 2023 at 12:13 AM Ilya Maximets wrote: > >> > >> On 6/14/23 21:03, Mike Pattrick wrote: > >>> The netdev receiving packets is supposed to provide the flags > >>> indicating if the L4

Re: [ovs-dev] [PATCH v15 4/4] userspace: Enable L4 checksum offloading by default.

2023-06-23 Thread Ilya Maximets
On 6/23/23 15:16, David Marchand wrote: > On Wed, Jun 21, 2023 at 12:13 AM Ilya Maximets wrote: >> >> On 6/14/23 21:03, Mike Pattrick wrote: >>> The netdev receiving packets is supposed to provide the flags >>> indicating if the L4 checksum was verified and it is OK or BAD, >>> otherwise the

Re: [ovs-dev] [PATCH v15 4/4] userspace: Enable L4 checksum offloading by default.

2023-06-23 Thread David Marchand
On Wed, Jun 21, 2023 at 12:13 AM Ilya Maximets wrote: > > On 6/14/23 21:03, Mike Pattrick wrote: > > The netdev receiving packets is supposed to provide the flags > > indicating if the L4 checksum was verified and it is OK or BAD, > > otherwise the stack will check when appropriate by software. >

Re: [ovs-dev] [PATCH v15 4/4] userspace: Enable L4 checksum offloading by default.

2023-06-20 Thread Ilya Maximets
On 6/21/23 00:14, Ilya Maximets wrote: > On 6/14/23 21:03, Mike Pattrick wrote: >> The netdev receiving packets is supposed to provide the flags >> indicating if the L4 checksum was verified and it is OK or BAD, >> otherwise the stack will check when appropriate by software. >> >> If the packet

Re: [ovs-dev] [PATCH v15 4/4] userspace: Enable L4 checksum offloading by default.

2023-06-20 Thread Ilya Maximets
On 6/14/23 21:03, Mike Pattrick wrote: > The netdev receiving packets is supposed to provide the flags > indicating if the L4 checksum was verified and it is OK or BAD, > otherwise the stack will check when appropriate by software. > > If the packet comes with good checksum, then postpone the >

[ovs-dev] [PATCH v15 4/4] userspace: Enable L4 checksum offloading by default.

2023-06-14 Thread Mike Pattrick
The netdev receiving packets is supposed to provide the flags indicating if the L4 checksum was verified and it is OK or BAD, otherwise the stack will check when appropriate by software. If the packet comes with good checksum, then postpone the checksum calculation to the egress device if needed.