Re: [ovs-dev] [PATCH v2] Allow bare ct_commits when no nested actions are required.

2020-08-06 Thread Mark Michelson
On 8/6/20 1:47 PM, Numan Siddique wrote: On Thu, Aug 6, 2020 at 11:03 PM Mark Michelson wrote: On 8/6/20 12:16 PM, Numan Siddique wrote: On Thu, Aug 6, 2020 at 8:22 PM Mark Michelson mailto:mmich...@redhat.com>> wrote: In the fixes commit below, ct_commit was changed to use nested

Re: [ovs-dev] [PATCH v2] Allow bare ct_commits when no nested actions are required.

2020-08-06 Thread Numan Siddique
On Thu, Aug 6, 2020 at 11:03 PM Mark Michelson wrote: > > On 8/6/20 12:16 PM, Numan Siddique wrote: > > > > > > On Thu, Aug 6, 2020 at 8:22 PM Mark Michelson > > wrote: > > > > In the fixes commit below, ct_commit was changed to use nested actions. > > This

Re: [ovs-dev] [PATCH v2] Allow bare ct_commits when no nested actions are required.

2020-08-06 Thread Mark Michelson
On 8/6/20 12:16 PM, Numan Siddique wrote: On Thu, Aug 6, 2020 at 8:22 PM Mark Michelson > wrote: In the fixes commit below, ct_commit was changed to use nested actions. This requires that curly braces be present for all ct_commits. When adjusting

Re: [ovs-dev] [PATCH v2] Allow bare ct_commits when no nested actions are required.

2020-08-06 Thread Numan Siddique
On Thu, Aug 6, 2020 at 8:22 PM Mark Michelson wrote: > In the fixes commit below, ct_commit was changed to use nested actions. > This requires that curly braces be present for all ct_commits. When > adjusting ovn-northd, some ct_commits were not updated to have them. > This commit changes the

Re: [ovs-dev] [PATCH v2] Allow bare ct_commits when no nested actions are required.

2020-08-06 Thread 0-day Robot
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless (lib/actions.c). error: could not build fake

[ovs-dev] [PATCH v2] Allow bare ct_commits when no nested actions are required.

2020-08-06 Thread Mark Michelson
In the fixes commit below, ct_commit was changed to use nested actions. This requires that curly braces be present for all ct_commits. When adjusting ovn-northd, some ct_commits were not updated to have them. This commit changes the behavior of the ct_commit action not to require curly braces if