Re: [ovs-dev] [PATCH v2] conntrack: Remove nat_conn introducing key directionality.

2023-09-01 Thread Ilya Maximets
On 8/30/23 21:28, Paolo Valerio wrote: > Ilya Maximets writes: > >> On 8/23/23 14:53, Paolo Valerio wrote: >>> From: hepeng >>> >>> The patch avoids the extra allocation for nat_conn. >>> Currently, when doing NAT, the userspace conntrack will use an extra >>> conn for the two directions in a

Re: [ovs-dev] [PATCH v2] conntrack: Remove nat_conn introducing key directionality.

2023-08-30 Thread Paolo Valerio
Ilya Maximets writes: > On 8/23/23 14:53, Paolo Valerio wrote: >> From: hepeng >> >> The patch avoids the extra allocation for nat_conn. >> Currently, when doing NAT, the userspace conntrack will use an extra >> conn for the two directions in a flow. However, each conn has actually >> the two

Re: [ovs-dev] [PATCH v2] conntrack: Remove nat_conn introducing key directionality.

2023-08-29 Thread Ilya Maximets
On 8/23/23 14:53, Paolo Valerio wrote: > From: hepeng > > The patch avoids the extra allocation for nat_conn. > Currently, when doing NAT, the userspace conntrack will use an extra > conn for the two directions in a flow. However, each conn has actually > the two keys for both orig and rev

Re: [ovs-dev] [PATCH v2] conntrack: Remove nat_conn introducing key directionality.

2023-08-28 Thread Aaron Conole
Paolo Valerio writes: > From: hepeng > > The patch avoids the extra allocation for nat_conn. > Currently, when doing NAT, the userspace conntrack will use an extra > conn for the two directions in a flow. However, each conn has actually > the two keys for both orig and rev directions. This

Re: [ovs-dev] [PATCH v2] conntrack: Remove nat_conn introducing key directionality.

2023-08-23 Thread 0-day Robot
Bleep bloop. Greetings Paolo Valerio, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author hepeng needs to sign off. WARNING: Unexpected sign-offs from developers who

[ovs-dev] [PATCH v2] conntrack: Remove nat_conn introducing key directionality.

2023-08-23 Thread Paolo Valerio
From: hepeng The patch avoids the extra allocation for nat_conn. Currently, when doing NAT, the userspace conntrack will use an extra conn for the two directions in a flow. However, each conn has actually the two keys for both orig and rev directions. This patch introduces a key_node[CT_DIRS]