Re: [ovs-dev] [PATCH v2] datapath-windows: Prevent ct-counters from getting redundantly incremented

2018-04-30 Thread Ben Pfaff
On Mon, Apr 30, 2018 at 11:47:43PM +0300, Alin Gabriel Serdean wrote: > > > > On 30 Apr 2018, at 23:36, Ben Pfaff wrote: > > > > On Mon, Apr 30, 2018 at 11:26:52PM +0300, Alin Gabriel Serdean wrote: > >> > >>> On 28 Apr 2018, at 21:26, Ben Pfaff wrote: > >>> > >>> On Fri, Apr 27, 2018 at 08:

Re: [ovs-dev] [PATCH v2] datapath-windows: Prevent ct-counters from getting redundantly incremented

2018-04-30 Thread Alin Gabriel Serdean
> On 30 Apr 2018, at 23:36, Ben Pfaff wrote: > > On Mon, Apr 30, 2018 at 11:26:52PM +0300, Alin Gabriel Serdean wrote: >> >>> On 28 Apr 2018, at 21:26, Ben Pfaff wrote: >>> >>> On Fri, Apr 27, 2018 at 08:03:43PM +0300, Alin Gabriel Serdean wrote: > On 27 Apr 2018, at 20:00, Anand K

Re: [ovs-dev] [PATCH v2] datapath-windows: Prevent ct-counters from getting redundantly incremented

2018-04-30 Thread Ben Pfaff
On Mon, Apr 30, 2018 at 11:26:52PM +0300, Alin Gabriel Serdean wrote: > > > On 28 Apr 2018, at 21:26, Ben Pfaff wrote: > > > > On Fri, Apr 27, 2018 at 08:03:43PM +0300, Alin Gabriel Serdean wrote: > >> > >>> On 27 Apr 2018, at 20:00, Anand Kumar wrote: > >>> > >>> The conntrack-counters ought

Re: [ovs-dev] [PATCH v2] datapath-windows: Prevent ct-counters from getting redundantly incremented

2018-04-30 Thread Alin Serdean
> On 27 Apr 2018, at 20:00, Anand Kumar wrote: > > The conntrack-counters ought to be incremented only if it's a new lookup > or if it's recirculated through a different zone for the first time. > > Signed-off-by: Anand Kumar Applied on master. Thanks Anand!

Re: [ovs-dev] [PATCH v2] datapath-windows: Prevent ct-counters from getting redundantly incremented

2018-04-30 Thread Alin Gabriel Serdean
> On 28 Apr 2018, at 21:26, Ben Pfaff wrote: > > On Fri, Apr 27, 2018 at 08:03:43PM +0300, Alin Gabriel Serdean wrote: >> >>> On 27 Apr 2018, at 20:00, Anand Kumar wrote: >>> >>> The conntrack-counters ought to be incremented only if it's a new lookup >>> or if it's recirculated through a dif

Re: [ovs-dev] [PATCH v2] datapath-windows: Prevent ct-counters from getting redundantly incremented

2018-04-28 Thread Ben Pfaff
On Fri, Apr 27, 2018 at 08:03:43PM +0300, Alin Gabriel Serdean wrote: > > > On 27 Apr 2018, at 20:00, Anand Kumar wrote: > > > > The conntrack-counters ought to be incremented only if it's a new lookup > > or if it's recirculated through a different zone for the first time. > > > > Signed-off-b

Re: [ovs-dev] [PATCH v2] datapath-windows: Prevent ct-counters from getting redundantly incremented

2018-04-27 Thread Alin Gabriel Serdean
> On 27 Apr 2018, at 20:00, Anand Kumar wrote: > > The conntrack-counters ought to be incremented only if it's a new lookup > or if it's recirculated through a different zone for the first time. > > Signed-off-by: Anand Kumar > --- > datapath-windows/ovsext/Conntrack.c | 7 --- > 1 file cha

[ovs-dev] [PATCH v2] datapath-windows: Prevent ct-counters from getting redundantly incremented

2018-04-27 Thread Anand Kumar
The conntrack-counters ought to be incremented only if it's a new lookup or if it's recirculated through a different zone for the first time. Signed-off-by: Anand Kumar --- datapath-windows/ovsext/Conntrack.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/datapath-win