Re: [ovs-dev] [PATCH v2] lib/tc: Support optional tunnel id

2019-02-11 Thread Simon Horman
On Mon, Feb 11, 2019 at 11:25:28AM +, Roi Dayan wrote: > > > On 11/02/2019 12:13, Simon Horman wrote: > > On Mon, Feb 11, 2019 at 09:57:10AM +, Roi Dayan wrote: > >> > >> > >> On 11/02/2019 11:11, Simon Horman wrote: > >>> On Sun, Feb 10, 2019 at 08:04:39AM +, Roi Dayan wrote: >

Re: [ovs-dev] [PATCH v2] lib/tc: Support optional tunnel id

2019-02-11 Thread Roi Dayan
On 11/02/2019 12:13, Simon Horman wrote: > On Mon, Feb 11, 2019 at 09:57:10AM +, Roi Dayan wrote: >> >> >> On 11/02/2019 11:11, Simon Horman wrote: >>> On Sun, Feb 10, 2019 at 08:04:39AM +, Roi Dayan wrote: On 04/02/2019 15:20, Roi Dayan wrote: > Hi Simon, >

Re: [ovs-dev] [PATCH v2] lib/tc: Support optional tunnel id

2019-02-11 Thread Simon Horman
On Mon, Feb 11, 2019 at 09:57:10AM +, Roi Dayan wrote: > > > On 11/02/2019 11:11, Simon Horman wrote: > > On Sun, Feb 10, 2019 at 08:04:39AM +, Roi Dayan wrote: > >> > >> > >> On 04/02/2019 15:20, Roi Dayan wrote: > >>> Hi Simon, > >>> > >>> I did some checks and think the cor

Re: [ovs-dev] [PATCH v2] lib/tc: Support optional tunnel id

2019-02-11 Thread Roi Dayan
On 11/02/2019 11:11, Simon Horman wrote: > On Sun, Feb 10, 2019 at 08:04:39AM +, Roi Dayan wrote: >> >> >> On 04/02/2019 15:20, Roi Dayan wrote: >>> Hi Simon, >>> >>> I did some checks and think the correct fix is to offload exact match. >>> if key is partial we can ignore th

Re: [ovs-dev] [PATCH v2] lib/tc: Support optional tunnel id

2019-02-11 Thread Simon Horman
On Sun, Feb 10, 2019 at 08:04:39AM +, Roi Dayan wrote: > > > On 04/02/2019 15:20, Roi Dayan wrote: > > Hi Simon, > > > > I did some checks and think the correct fix is to offload exact match. > > if key is partial we can ignore the mask and offload exact match and > > it w

Re: [ovs-dev] [PATCH v2] lib/tc: Support optional tunnel id

2019-02-10 Thread Roi Dayan
On 04/02/2019 15:20, Roi Dayan wrote: > Hi Simon, > > I did some checks and think the correct fix is to offload exact match. > if key is partial we can ignore the mask and offload exact match and > it will be correct as we do more strict matching. > > it is also docum

Re: [ovs-dev] [PATCH v2] lib/tc: Support optional tunnel id

2019-02-04 Thread Roi Dayan
On Mon, Feb 4, 2019 at 11:00 AM Simon Horman wrote: > > > > On Sun, 3 Feb 2019 at 12:03, Roi Dayan wrote: >> >> On Fri, Feb 1, 2019 at 4:05 PM Simon Horman >> wrote: >> > >> > Thanks Roi, >> > >> > On Thu, 31 Jan 2019 at 15:52, Roi Dayan wrote: >> > >> > > >> > > >> > > On 31/01/2019 15:32, Ro

Re: [ovs-dev] [PATCH v2] lib/tc: Support optional tunnel id

2019-02-04 Thread Simon Horman
On Sun, 3 Feb 2019 at 12:03, Roi Dayan wrote: > On Fri, Feb 1, 2019 at 4:05 PM Simon Horman > wrote: > > > > Thanks Roi, > > > > On Thu, 31 Jan 2019 at 15:52, Roi Dayan wrote: > > > > > > > > > > > On 31/01/2019 15:32, Roi Dayan wrote: > > > > > > > > On 31/01/2019 11:58, Simon Horman wrote: >

Re: [ovs-dev] [PATCH v2] lib/tc: Support optional tunnel id

2019-02-03 Thread Roi Dayan
On Fri, Feb 1, 2019 at 4:05 PM Simon Horman wrote: > > Thanks Roi, > > On Thu, 31 Jan 2019 at 15:52, Roi Dayan wrote: > > > > > > > On 31/01/2019 15:32, Roi Dayan wrote: > > > > > > On 31/01/2019 11:58, Simon Horman wrote: > > >> On Mon, Jan 21, 2019 at 05:32:37PM +0200, Adi Nissim wrote: > > >>>

Re: [ovs-dev] [PATCH v2] lib/tc: Support optional tunnel id

2019-02-01 Thread Simon Horman
Thanks Roi, On Thu, 31 Jan 2019 at 15:52, Roi Dayan wrote: > > > On 31/01/2019 15:32, Roi Dayan wrote: > > > > On 31/01/2019 11:58, Simon Horman wrote: > >> On Mon, Jan 21, 2019 at 05:32:37PM +0200, Adi Nissim wrote: > >>> Currently the TC tunnel_key action is always > >>> initialized with the g

Re: [ovs-dev] [PATCH v2] lib/tc: Support optional tunnel id

2019-01-31 Thread Roi Dayan
On 31/01/2019 15:32, Roi Dayan wrote: > > On 31/01/2019 11:58, Simon Horman wrote: >> On Mon, Jan 21, 2019 at 05:32:37PM +0200, Adi Nissim wrote: >>> Currently the TC tunnel_key action is always >>> initialized with the given tunnel id value. However, >>> some tunneling protocols define the tun

Re: [ovs-dev] [PATCH v2] lib/tc: Support optional tunnel id

2019-01-31 Thread Roi Dayan
On 31/01/2019 11:58, Simon Horman wrote: > On Mon, Jan 21, 2019 at 05:32:37PM +0200, Adi Nissim wrote: >> Currently the TC tunnel_key action is always >> initialized with the given tunnel id value. However, >> some tunneling protocols define the tunnel id as an optional field. >> >> This patch i

Re: [ovs-dev] [PATCH v2] lib/tc: Support optional tunnel id

2019-01-31 Thread Simon Horman
On Mon, Jan 21, 2019 at 05:32:37PM +0200, Adi Nissim wrote: > Currently the TC tunnel_key action is always > initialized with the given tunnel id value. However, > some tunneling protocols define the tunnel id as an optional field. > > This patch initializes the id field of tunnel_key:set and tunn

Re: [ovs-dev] [PATCH v2] lib/tc: Support optional tunnel id

2019-01-31 Thread Simon Horman
On Thu, Jan 31, 2019 at 07:21:53AM +, Roi Dayan wrote: > Hi Simon, > > Just pinging about this change. Sorry for the delay, I am looking at it now. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] lib/tc: Support optional tunnel id

2019-01-30 Thread Roi Dayan
Hi Simon, Just pinging about this change. Thanks, Roi On 21/01/2019 17:32, Adi Nissim wrote: > Currently the TC tunnel_key action is always > initialized with the given tunnel id value. However, > some tunneling protocols define the tunnel id as an optional field. > > This patch initializes th

[ovs-dev] [PATCH v2] lib/tc: Support optional tunnel id

2019-01-21 Thread Adi Nissim
Currently the TC tunnel_key action is always initialized with the given tunnel id value. However, some tunneling protocols define the tunnel id as an optional field. This patch initializes the id field of tunnel_key:set and tunnel_key:unset only if a value is provided. In the case that a tunnel k