Re: [ovs-dev] [PATCH v2] netdev-dpdk: Refactor the DPDK transmit path.

2022-01-12 Thread Flavio Leitner
Hello Sunil, Marko and Ian. Mike worked to identify the reason for the performance issue reported by you a while ago. He summarized below. I wonder if you can give a try on his patch too and tell us if we are on the right track. Thanks, fbl On Wed, Jan 05, 2022 at 03:01:47PM -0500, Mike

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Refactor the DPDK transmit path.

2022-01-05 Thread Mike Pattrick
Hello Flavio, Great patch, I think you really did a lot to improve the code here and I think that's borne out by the consistent performance improvements across multiple tests. Regarding the 4% regression that Intel detected, I found the following white paper to describe the "scatter" test:

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Refactor the DPDK transmit path.

2021-01-13 Thread Flavio Leitner
Hi Marko, On Wed, Jan 13, 2021 at 10:51:03AM +, Kovacevic, Marko wrote: > Hi Flavio, > > > So, I see a small performance gain. Can you provide a more detailed > > test description? I wonder if we are testing the same thing. > > VSPERF phy2phy_tput uses 2 dpdk pmds and performs zero packet

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Refactor the DPDK transmit path.

2021-01-13 Thread Kovacevic, Marko
Hi Flavio, > So, I see a small performance gain. Can you provide a more detailed > test description? I wonder if we are testing the same thing. VSPERF phy2phy_tput uses 2 dpdk pmds and performs zero packet loss test(RFC2544) with bidirectional traffic. > > > and PVP test results are in line

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Refactor the DPDK transmit path.

2021-01-11 Thread David Marchand
On Sun, Jan 10, 2021 at 4:05 AM Flavio Leitner wrote: > > This patch split out the common code between vhost and > dpdk transmit paths to shared functions to simplify the > code and fix an issue. > > The issue is that the packet coming from non-DPDK device > and egressing on a DPDK device

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Refactor the DPDK transmit path.

2021-01-11 Thread Flavio Leitner
chand ; Flavio Leitner > > > > Subject: [ovs-dev] [PATCH v2] netdev-dpdk: Refactor the DPDK transmit > > path. > > > > This patch split out the common code between vhost and dpdk transmit > > paths to shared functions to simplify the code and fix an issue. >

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Refactor the DPDK transmit path.

2021-01-11 Thread Pai G, Sunil
Hi Flavio, > -Original Message- > From: dev On Behalf Of Flavio Leitner > Sent: Sunday, January 10, 2021 8:35 AM > To: d...@openvswitch.org > Cc: David Marchand ; Flavio Leitner > > Subject: [ovs-dev] [PATCH v2] netdev-dpdk: Refactor the DPDK transmit > path. &

[ovs-dev] [PATCH v2] netdev-dpdk: Refactor the DPDK transmit path.

2021-01-09 Thread Flavio Leitner
This patch split out the common code between vhost and dpdk transmit paths to shared functions to simplify the code and fix an issue. The issue is that the packet coming from non-DPDK device and egressing on a DPDK device currently skips the hwol preparation. This also have the side effect of