Re: [ovs-dev] [PATCH v2 05/16] list: use short version of safe loops if possible

2022-02-15 Thread Ilya Maximets
On 2/15/22 13:58, Adrian Moreno wrote: > > > On 2/15/22 13:54, Ilya Maximets wrote: >> On 2/15/22 13:49, Adrian Moreno wrote: >>> >>> >>> On 2/15/22 13:42, Adrian Moreno wrote: On 2/14/22 18:30, Ilya Maximets wrote: > On 2/14/22 11:13, Adrian Moreno wrote: >> Using the SHOR

Re: [ovs-dev] [PATCH v2 05/16] list: use short version of safe loops if possible

2022-02-15 Thread Adrian Moreno
On 2/15/22 13:54, Ilya Maximets wrote: On 2/15/22 13:49, Adrian Moreno wrote: On 2/15/22 13:42, Adrian Moreno wrote: On 2/14/22 18:30, Ilya Maximets wrote: On 2/14/22 11:13, Adrian Moreno wrote: Using the SHORT version of the *_SAFE loops makes the code cleaner and less error-prone. So,

Re: [ovs-dev] [PATCH v2 05/16] list: use short version of safe loops if possible

2022-02-15 Thread Ilya Maximets
On 2/15/22 13:49, Adrian Moreno wrote: > > > On 2/15/22 13:42, Adrian Moreno wrote: >> >> >> On 2/14/22 18:30, Ilya Maximets wrote: >>> On 2/14/22 11:13, Adrian Moreno wrote: Using the SHORT version of the *_SAFE loops makes the code cleaner and less error-prone. So, use the SHORT versi

Re: [ovs-dev] [PATCH v2 05/16] list: use short version of safe loops if possible

2022-02-15 Thread Adrian Moreno
On 2/15/22 13:42, Adrian Moreno wrote: On 2/14/22 18:30, Ilya Maximets wrote: On 2/14/22 11:13, Adrian Moreno wrote: Using the SHORT version of the *_SAFE loops makes the code cleaner and less error-prone. So, use the SHORT version and remove the extra variable when possible. In order to b

Re: [ovs-dev] [PATCH v2 05/16] list: use short version of safe loops if possible

2022-02-15 Thread Adrian Moreno
On 2/14/22 18:30, Ilya Maximets wrote: On 2/14/22 11:13, Adrian Moreno wrote: Using the SHORT version of the *_SAFE loops makes the code cleaner and less error-prone. So, use the SHORT version and remove the extra variable when possible. In order to be able to use both long and short versions

Re: [ovs-dev] [PATCH v2 05/16] list: use short version of safe loops if possible

2022-02-14 Thread Ilya Maximets
On 2/14/22 11:13, Adrian Moreno wrote: > Using the SHORT version of the *_SAFE loops makes the code cleaner > and less error-prone. So, use the SHORT version and remove the extra > variable when possible. > > In order to be able to use both long and short versions without changing > the name of th

Re: [ovs-dev] [PATCH v2 05/16] list: use short version of safe loops if possible

2022-02-14 Thread 0-day Robot
Bleep bloop. Greetings Adrian Moreno, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Use ovs_assert() in place of assert() #1174 FILE: tests/test-list.c:148:

[ovs-dev] [PATCH v2 05/16] list: use short version of safe loops if possible

2022-02-14 Thread Adrian Moreno
Using the SHORT version of the *_SAFE loops makes the code cleaner and less error-prone. So, use the SHORT version and remove the extra variable when possible. In order to be able to use both long and short versions without changing the name of the macro for all the clients, overload the existing