Re: [ovs-dev] [PATCH v2 1/2] ovsdb: Preserve column diffs read from the storage.

2024-01-11 Thread Ilya Maximets
On 1/11/24 16:02, Dumitru Ceara wrote: > On 1/11/24 15:44, Ilya Maximets wrote: >> On 1/10/24 14:12, Dumitru Ceara wrote: >>> On 1/9/24 20:54, Ilya Maximets wrote: Database file contains the column diff, but it is discarded once the 'new' state of a row is constructed. Keep it in the

Re: [ovs-dev] [PATCH v2 1/2] ovsdb: Preserve column diffs read from the storage.

2024-01-11 Thread Dumitru Ceara
On 1/11/24 15:44, Ilya Maximets wrote: > On 1/10/24 14:12, Dumitru Ceara wrote: >> On 1/9/24 20:54, Ilya Maximets wrote: >>> Database file contains the column diff, but it is discarded once >>> the 'new' state of a row is constructed. Keep it in the transaction >>> row, as it can be used later by

Re: [ovs-dev] [PATCH v2 1/2] ovsdb: Preserve column diffs read from the storage.

2024-01-11 Thread Ilya Maximets
On 1/10/24 14:12, Dumitru Ceara wrote: > On 1/9/24 20:54, Ilya Maximets wrote: >> Database file contains the column diff, but it is discarded once >> the 'new' state of a row is constructed. Keep it in the transaction >> row, as it can be used later by other parts of the code. >> >> Diffs do not

Re: [ovs-dev] [PATCH v2 1/2] ovsdb: Preserve column diffs read from the storage.

2024-01-10 Thread Dumitru Ceara
On 1/9/24 20:54, Ilya Maximets wrote: > Database file contains the column diff, but it is discarded once > the 'new' state of a row is constructed. Keep it in the transaction > row, as it can be used later by other parts of the code. > > Diffs do not live long, we keep them around only while

[ovs-dev] [PATCH v2 1/2] ovsdb: Preserve column diffs read from the storage.

2024-01-09 Thread Ilya Maximets
Database file contains the column diff, but it is discarded once the 'new' state of a row is constructed. Keep it in the transaction row, as it can be used later by other parts of the code. Diffs do not live long, we keep them around only while transaction is alive, so should not affect memory