Re: [ovs-dev] [PATCH v2 1/5] Enable kernel probes and map stream probes onto them

2020-06-04 Thread Anton Ivanov
On 04/06/2020 15:43, Mark Michelson wrote: Hi Anton, a couple of comments in-line below. On 6/2/20 3:21 AM, anton.iva...@cambridgegreys.com wrote: From: Anton Ivanov 1. Fix probe logic. The stream_or_pstream_needs_probes function returning a mix of integer and boolean. As a result probes

Re: [ovs-dev] [PATCH v2 1/5] Enable kernel probes and map stream probes onto them

2020-06-04 Thread Mark Michelson
Hi Anton, a couple of comments in-line below. On 6/2/20 3:21 AM, anton.iva...@cambridgegreys.com wrote: From: Anton Ivanov 1. Fix probe logic. The stream_or_pstream_needs_probes function returning a mix of integer and boolean. As a result probes were NOT turned off in a number of cases on

[ovs-dev] [PATCH v2 1/5] Enable kernel probes and map stream probes onto them

2020-06-02 Thread anton . ivanov
From: Anton Ivanov 1. Fix probe logic. The stream_or_pstream_needs_probes function returning a mix of integer and boolean. As a result probes were NOT turned off in a number of cases on unix domain sockets and other transports where there should be no probing. It now returns -1 (do not know), 0