Re: [ovs-dev] [PATCH v2 2/2] OVN: Add support for periodic router advertisements.

On Fri, Nov 03, 2017 at 04:24 PM GMT, Mark Michelson wrote: > Thanks for the reviews Jakub. I've added an in-line comment below. > Otherwise consider that there is an implicit "Will do!" on all of your > other suggestions. > > On Fri, Nov 3, 2017 at 11:04 AM Jakub Sitnicki wrote:

Re: [ovs-dev] [PATCH v2 2/2] OVN: Add support for periodic router advertisements.

On Fri, Nov 3, 2017 at 9:54 PM, Mark Michelson wrote: > Thanks for the reviews Jakub. I've added an in-line comment below. > Otherwise consider that there is an implicit "Will do!" on all of your > other suggestions. > > On Fri, Nov 3, 2017 at 11:04 AM Jakub Sitnicki

Re: [ovs-dev] [PATCH v2 2/2] OVN: Add support for periodic router advertisements.

Thanks for the reviews Jakub. I've added an in-line comment below. Otherwise consider that there is an implicit "Will do!" on all of your other suggestions. On Fri, Nov 3, 2017 at 11:04 AM Jakub Sitnicki wrote: > Hi again Mark, > > A batch of nit-picks/suggestions & a question

Re: [ovs-dev] [PATCH v2 2/2] OVN: Add support for periodic router advertisements.

Hi again Mark, A batch of nit-picks/suggestions & a question that I've collected so far when reading through this patch. Please apply as you see fit. On Thu, Nov 02, 2017 at 08:47 PM GMT, Mark Michelson wrote: > This change adds three new options to the Northbound > Logical_Router_Port's

[ovs-dev] [PATCH v2 2/2] OVN: Add support for periodic router advertisements.

This change adds three new options to the Northbound Logical_Router_Port's ipv6_ra_configs option: * send_periodic: If set to "true", then OVN will send periodic router advertisements out of this router port. * max_interval: The maximum amount of time to wait between sending periodic router