Thanks a lot for the review and for the fix to the comment. I folded in
that fix and applied these patches to master.
On Fri, Jan 26, 2018 at 04:41:58PM -0800, Yifeng Sun wrote:
> Thanks for the patch. Tested and looks good to me.
>
> I feel it may be a little better if the comment is changed li
Thanks for the patch. Tested and looks good to me.
I feel it may be a little better if the comment is changed like below:
- * can do something like "ovs-ofctl compose-packet udp | tcpdump -
-r-" to
+ * can do something like "ovs-ofctl compose-packet udp --pcap | tcpdump
- -r-" to
Tested
I don't feel obligated to add a bunch of automatic tests for
flow_compose(), but this is handy for manual testing or for simple packet
generation.
Signed-off-by: Ben Pfaff
---
utilities/ovs-ofctl.c | 72 +++
1 file changed, 72 insertions(+)
diff -