Re: [ovs-dev] [PATCH v2 3/3] netdev-dpdk: reset queue number for vhost devices on vm shutdown

On 6/27/2019 8:26 AM, David Marchand wrote: Hello Ian, On Wed, Jun 26, 2019 at 11:10 PM Ian Stokes > wrote: On 4/18/2019 3:44 PM, Ilya Maximets wrote: > On 18.04.2019 17:05, David Marchand wrote: >> Ok, how should I proceed ? >> Can I still submi

Re: [ovs-dev] [PATCH v2 3/3] netdev-dpdk: reset queue number for vhost devices on vm shutdown

Hello Ian, On Wed, Jun 26, 2019 at 11:10 PM Ian Stokes wrote: > On 4/18/2019 3:44 PM, Ilya Maximets wrote: > > On 18.04.2019 17:05, David Marchand wrote: > >> Ok, how should I proceed ? > >> Can I still submit the 3 patches together, to finish handling the last > comments ? > > > > Yes, I think

Re: [ovs-dev] [PATCH v2 3/3] netdev-dpdk: reset queue number for vhost devices on vm shutdown

On 4/18/2019 3:44 PM, Ilya Maximets wrote: On 18.04.2019 17:05, David Marchand wrote: On Thu, Apr 18, 2019 at 1:51 PM Ilya Maximets mailto:i.maxim...@samsung.com>> wrote: On 18.04.2019 14:26, David Marchand wrote: > On Wed, Apr 17, 2019 at 4:27 PM Kevin Traynor mailto:ktray...@redha

Re: [ovs-dev] [PATCH v2 3/3] netdev-dpdk: reset queue number for vhost devices on vm shutdown

On 18.04.2019 17:05, David Marchand wrote: > On Thu, Apr 18, 2019 at 1:51 PM Ilya Maximets > wrote: > > > > On 18.04.2019 14:26, David Marchand wrote: > > On Wed, Apr 17, 2019 at 4:27 PM Kevin Traynor

Re: [ovs-dev] [PATCH v2 3/3] netdev-dpdk: reset queue number for vhost devices on vm shutdown

On Thu, Apr 18, 2019 at 1:51 PM Ilya Maximets wrote: > > > On 18.04.2019 14:26, David Marchand wrote: > > On Wed, Apr 17, 2019 at 4:27 PM Kevin Traynor > wrote: > > > > On 16/04/2019 10:45, David Marchand wrote: > > > > > Note: this patch requires a fix for th

Re: [ovs-dev] [PATCH v2 3/3] netdev-dpdk: reset queue number for vhost devices on vm shutdown

On 18.04.2019 14:26, David Marchand wrote: > On Wed, Apr 17, 2019 at 4:27 PM Kevin Traynor > wrote: > > On 16/04/2019 10:45, David Marchand wrote: > > > Note: this patch requires a fix for the vhost library submitted here: > > http://patchwork.dpdk.org/

Re: [ovs-dev] [PATCH v2 3/3] netdev-dpdk: reset queue number for vhost devices on vm shutdown

On Wed, Apr 17, 2019 at 4:27 PM Kevin Traynor wrote: > On 16/04/2019 10:45, David Marchand wrote: > > > Note: this patch requires a fix for the vhost library submitted here: > > http://patchwork.dpdk.org/patch/52680/ > > > > Without it, this change will do nothing but have openvswitch complain >

Re: [ovs-dev] [PATCH v2 3/3] netdev-dpdk: reset queue number for vhost devices on vm shutdown

On Wed, Apr 17, 2019 at 12:21 PM Ilya Maximets wrote: > On 17.04.2019 11:37, David Marchand wrote: > > On Tue, Apr 16, 2019 at 4:01 PM Ilya Maximets > wrote: > > > +LIST_FOR_EACH (dev, list_node, &dpdk_list) { > > > +ovs_mutex_lock(&dev->mutex);

Re: [ovs-dev] [PATCH v2 3/3] netdev-dpdk: reset queue number for vhost devices on vm shutdown

On 16/04/2019 10:45, David Marchand wrote: > Rather than poll all disabled queues and waste some memory for vms that > have been shutdown, we can reconfigure when receiving a destroy > connection notification from the vhost library. > > $ while true; do > ovs-appctl dpif-netdev/pmd-rxq-show |awk

Re: [ovs-dev] [PATCH v2 3/3] netdev-dpdk: reset queue number for vhost devices on vm shutdown

On 17.04.2019 11:37, David Marchand wrote: > > > > On Tue, Apr 16, 2019 at 4:01 PM Ilya Maximets > wrote: > > On 16.04.2019 12:45, David Marchand wrote: > > Rather than poll all disabled queues and waste some memory for vms that > > have been shutdown

Re: [ovs-dev] [PATCH v2 3/3] netdev-dpdk: reset queue number for vhost devices on vm shutdown

On Tue, Apr 16, 2019 at 4:01 PM Ilya Maximets wrote: > On 16.04.2019 12:45, David Marchand wrote: > > Rather than poll all disabled queues and waste some memory for vms that > > have been shutdown, we can reconfigure when receiving a destroy > > connection notification from the vhost library. > >

Re: [ovs-dev] [PATCH v2 3/3] netdev-dpdk: reset queue number for vhost devices on vm shutdown

On 16.04.2019 12:45, David Marchand wrote: > Rather than poll all disabled queues and waste some memory for vms that > have been shutdown, we can reconfigure when receiving a destroy > connection notification from the vhost library. > > $ while true; do > ovs-appctl dpif-netdev/pmd-rxq-show |awk

[ovs-dev] [PATCH v2 3/3] netdev-dpdk: reset queue number for vhost devices on vm shutdown

Rather than poll all disabled queues and waste some memory for vms that have been shutdown, we can reconfigure when receiving a destroy connection notification from the vhost library. $ while true; do ovs-appctl dpif-netdev/pmd-rxq-show |awk ' /port: / { tot++; if ($NF == "disabled") {