Re: [ovs-dev] [PATCH v2 5/5] datapath-windows: Add support for OVS_KEY_ATTR_TCP set action

2017-01-10 Thread Alin Serdean
[ovs-dev] [PATCH v2 5/5] datapath-windows: Add support for > OVS_KEY_ATTR_TCP set action > > Please see my comment inline: > >+ > >+ASSERT(layers->value != 0); > >+ > >+if (!layers->isUdp) { > > Sai: This is incorrect. Should be checking for !layer

Re: [ovs-dev] [PATCH v2 5/5] datapath-windows: Add support for OVS_KEY_ATTR_TCP set action

2017-01-09 Thread Sairam Venugopal
Please see my comment inline: On 1/6/17, 11:33 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" wrote: >This patch adds support for set action with OVS_KEY_ATTR_TCP attribute >(change TCP source or

[ovs-dev] [PATCH v2 5/5] datapath-windows: Add support for OVS_KEY_ATTR_TCP set action

2017-01-06 Thread Alin Serdean
This patch adds support for set action with OVS_KEY_ATTR_TCP attribute (change TCP source or destination port). If the source or destination TCP port was changed, update the TCP checksum. A sample flow can look like the following: set(tcp(src=80,dst=443)) Signed-off-by: Alin Gabriel Serdean