Re: [ovs-dev] [PATCH v2 5/5] odp-util: Always report ODP_FIT_TOO_LITTLE for IGMP.

2018-02-06 Thread Ben Pfaff
Thanks. I'll look forward to a patch from you to keep slow_path flows. On Tue, Feb 06, 2018 at 08:08:32PM +0800, Huanle Han wrote: > "ODP_FIT_TOO_LITTLE" patches are good to me. > > On Tue, Feb 6, 2018 at 1:31 AM, Ben Pfaff wrote: > > That sounds like a good idea. Do you want to try to write u

Re: [ovs-dev] [PATCH v2 5/5] odp-util: Always report ODP_FIT_TOO_LITTLE for IGMP.

2018-02-06 Thread Huanle Han
"ODP_FIT_TOO_LITTLE" patches are good to me. On Tue, Feb 6, 2018 at 1:31 AM, Ben Pfaff wrote: > That sounds like a good idea. Do you want to try to write up a patch > for that approach? > > The current series still seems like a good idea to me, do you have an > opinion? > > On Mon, Feb 05, 2018

Re: [ovs-dev] [PATCH v2 5/5] odp-util: Always report ODP_FIT_TOO_LITTLE for IGMP.

2018-02-05 Thread Ben Pfaff
That sounds like a good idea. Do you want to try to write up a patch for that approach? The current series still seems like a good idea to me, do you have an opinion? On Mon, Feb 05, 2018 at 07:57:20PM +0800, Huanle Han wrote: > The patches make "ODP_FIT_TOO_LITTLE" logic more clear for me. > Bu

Re: [ovs-dev] [PATCH v2 5/5] odp-util: Always report ODP_FIT_TOO_LITTLE for IGMP.

2018-02-05 Thread Huanle Han
The patches make "ODP_FIT_TOO_LITTLE" logic more clear for me. But it seems not fix the problem I mentioned at beginnig: revalidate_ukey__() always return UKEY_DELETE for igmp, because flow_wildcards_has_extra() return true. Should we UKEY_KEEP igmp or other "ODP_FIT_TOO_LITTLE" flows whose action

[ovs-dev] [PATCH v2 5/5] odp-util: Always report ODP_FIT_TOO_LITTLE for IGMP.

2018-01-24 Thread Ben Pfaff
OVS datapaths don't understand or parse IGMP fields, but OVS userspace does, so this commit updates odp_flow_key_to_flow() to report that properly to the caller. Reported-by: Huanle Han Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2018-January/343665.html Signed-off-by: Ben Pfaff