Re: [ovs-dev] [PATCH v24 3/8] netdev-offload-tc: Introduce group ID management API

2023-03-29 Thread Chris Mi via dev
On 3/29/2023 7:49 PM, Eelco Chaudron wrote: On 29 Mar 2023, at 13:41, Chris Mi wrote: On 3/29/2023 6:03 PM, Eelco Chaudron wrote: On 23 Mar 2023, at 13:07, Eelco Chaudron wrote: On 23 Mar 2023, at 12:24, Chris Mi wrote: I ran it 100 times. All passed. Visually inspecting this, it

Re: [ovs-dev] [PATCH v24 3/8] netdev-offload-tc: Introduce group ID management API

2023-03-29 Thread Eelco Chaudron
On 29 Mar 2023, at 13:41, Chris Mi wrote: > On 3/29/2023 6:03 PM, Eelco Chaudron wrote: >> >> On 23 Mar 2023, at 13:07, Eelco Chaudron wrote: >> >>> On 23 Mar 2023, at 12:24, Chris Mi wrote: >> >> >> I ran it 100 times. All passed. > Visually inspecting this, it looks fine, however, is

Re: [ovs-dev] [PATCH v24 3/8] netdev-offload-tc: Introduce group ID management API

2023-03-29 Thread Chris Mi via dev
On 3/29/2023 6:03 PM, Eelco Chaudron wrote: On 23 Mar 2023, at 13:07, Eelco Chaudron wrote: On 23 Mar 2023, at 12:24, Chris Mi wrote: I ran it 100 times. All passed. Visually inspecting this, it looks fine, however, is this failing without passing the actions parts? Yes. Only the first

Re: [ovs-dev] [PATCH v24 3/8] netdev-offload-tc: Introduce group ID management API

2023-03-29 Thread Eelco Chaudron
On 23 Mar 2023, at 13:07, Eelco Chaudron wrote: > On 23 Mar 2023, at 12:24, Chris Mi wrote: I ran it 100 times. All passed. >>> Visually inspecting this, it looks fine, however, is this failing without >>> passing the actions parts? >> Yes. Only the first sampled packet has tunnel

Re: [ovs-dev] [PATCH v24 3/8] netdev-offload-tc: Introduce group ID management API

2023-03-28 Thread Chris Mi via dev
On 3/23/2023 8:07 PM, Eelco Chaudron wrote: On 23 Mar 2023, at 12:24, Chris Mi wrote: On 3/23/2023 5:47 PM, Eelco Chaudron wrote: On 23 Mar 2023, at 10:28, Chris Mi wrote: On 3/22/2023 6:45 PM, Eelco Chaudron wrote: On 22 Mar 2023, at 7:15, Chris Mi wrote: On 3/20/2023 6:04 PM, Eelco

Re: [ovs-dev] [PATCH v24 3/8] netdev-offload-tc: Introduce group ID management API

2023-03-23 Thread Chris Mi via dev
On 3/23/2023 8:07 PM, Eelco Chaudron wrote: On 23 Mar 2023, at 12:24, Chris Mi wrote: On 3/23/2023 5:47 PM, Eelco Chaudron wrote: On 23 Mar 2023, at 10:28, Chris Mi wrote: On 3/22/2023 6:45 PM, Eelco Chaudron wrote: On 22 Mar 2023, at 7:15, Chris Mi wrote: On 3/20/2023 6:04 PM, Eelco

Re: [ovs-dev] [PATCH v24 3/8] netdev-offload-tc: Introduce group ID management API

2023-03-23 Thread Eelco Chaudron
On 23 Mar 2023, at 12:24, Chris Mi wrote: > On 3/23/2023 5:47 PM, Eelco Chaudron wrote: >> >> On 23 Mar 2023, at 10:28, Chris Mi wrote: >> >>> On 3/22/2023 6:45 PM, Eelco Chaudron wrote: On 22 Mar 2023, at 7:15, Chris Mi wrote: > On 3/20/2023 6:04 PM, Eelco Chaudron wrote: >>

Re: [ovs-dev] [PATCH v24 3/8] netdev-offload-tc: Introduce group ID management API

2023-03-23 Thread Chris Mi via dev
On 3/23/2023 5:47 PM, Eelco Chaudron wrote: On 23 Mar 2023, at 10:28, Chris Mi wrote: On 3/22/2023 6:45 PM, Eelco Chaudron wrote: On 22 Mar 2023, at 7:15, Chris Mi wrote: On 3/20/2023 6:04 PM, Eelco Chaudron wrote: On 20 Mar 2023, at 6:44, Chris Mi wrote: On 3/16/2023 5:09 PM, Eelco

Re: [ovs-dev] [PATCH v24 3/8] netdev-offload-tc: Introduce group ID management API

2023-03-23 Thread Chris Mi via dev
On 3/23/2023 5:47 PM, Eelco Chaudron wrote: On 23 Mar 2023, at 10:28, Chris Mi wrote: On 3/22/2023 6:45 PM, Eelco Chaudron wrote: On 22 Mar 2023, at 7:15, Chris Mi wrote: On 3/20/2023 6:04 PM, Eelco Chaudron wrote: On 20 Mar 2023, at 6:44, Chris Mi wrote: On 3/16/2023 5:09 PM, Eelco

Re: [ovs-dev] [PATCH v24 3/8] netdev-offload-tc: Introduce group ID management API

2023-03-23 Thread Eelco Chaudron
On 23 Mar 2023, at 10:28, Chris Mi wrote: > On 3/22/2023 6:45 PM, Eelco Chaudron wrote: >> >> On 22 Mar 2023, at 7:15, Chris Mi wrote: >> >>> On 3/20/2023 6:04 PM, Eelco Chaudron wrote: On 20 Mar 2023, at 6:44, Chris Mi wrote: > On 3/16/2023 5:09 PM, Eelco Chaudron wrote: >>

Re: [ovs-dev] [PATCH v24 3/8] netdev-offload-tc: Introduce group ID management API

2023-03-23 Thread Chris Mi via dev
On 3/22/2023 6:45 PM, Eelco Chaudron wrote: On 22 Mar 2023, at 7:15, Chris Mi wrote: On 3/20/2023 6:04 PM, Eelco Chaudron wrote: On 20 Mar 2023, at 6:44, Chris Mi wrote: On 3/16/2023 5:09 PM, Eelco Chaudron wrote: On 1 Mar 2023, at 8:22, Chris Mi wrote: When offloading sample action to

Re: [ovs-dev] [PATCH v24 3/8] netdev-offload-tc: Introduce group ID management API

2023-03-22 Thread Chris Mi via dev
On 3/22/2023 7:10 PM, Eelco Chaudron wrote: On 22 Mar 2023, at 11:45, Eelco Chaudron wrote: On 22 Mar 2023, at 7:15, Chris Mi wrote: On 3/20/2023 6:04 PM, Eelco Chaudron wrote: On 20 Mar 2023, at 6:44, Chris Mi wrote: On 3/16/2023 5:09 PM, Eelco Chaudron wrote: On 1 Mar 2023, at 8:22,

Re: [ovs-dev] [PATCH v24 3/8] netdev-offload-tc: Introduce group ID management API

2023-03-22 Thread Eelco Chaudron
On 22 Mar 2023, at 11:45, Eelco Chaudron wrote: > On 22 Mar 2023, at 7:15, Chris Mi wrote: > >> On 3/20/2023 6:04 PM, Eelco Chaudron wrote: >>> On 20 Mar 2023, at 6:44, Chris Mi wrote: >>> On 3/16/2023 5:09 PM, Eelco Chaudron wrote: > On 1 Mar 2023, at 8:22, Chris Mi wrote: >

Re: [ovs-dev] [PATCH v24 3/8] netdev-offload-tc: Introduce group ID management API

2023-03-22 Thread Eelco Chaudron
On 22 Mar 2023, at 7:15, Chris Mi wrote: > On 3/20/2023 6:04 PM, Eelco Chaudron wrote: >> On 20 Mar 2023, at 6:44, Chris Mi wrote: >> >>> On 3/16/2023 5:09 PM, Eelco Chaudron wrote: On 1 Mar 2023, at 8:22, Chris Mi wrote: > When offloading sample action to TC, userspace creates a

Re: [ovs-dev] [PATCH v24 3/8] netdev-offload-tc: Introduce group ID management API

2023-03-22 Thread Chris Mi via dev
On 3/20/2023 6:04 PM, Eelco Chaudron wrote: On 20 Mar 2023, at 6:44, Chris Mi wrote: On 3/16/2023 5:09 PM, Eelco Chaudron wrote: On 1 Mar 2023, at 8:22, Chris Mi wrote: When offloading sample action to TC, userspace creates a unique ID to map sFlow action and tunnel info and passes this ID

Re: [ovs-dev] [PATCH v24 3/8] netdev-offload-tc: Introduce group ID management API

2023-03-20 Thread Eelco Chaudron
On 20 Mar 2023, at 6:44, Chris Mi wrote: > On 3/16/2023 5:09 PM, Eelco Chaudron wrote: >> On 1 Mar 2023, at 8:22, Chris Mi wrote: >> >>> When offloading sample action to TC, userspace creates a unique ID >>> to map sFlow action and tunnel info and passes this ID to kernel >>> instead of the

Re: [ovs-dev] [PATCH v24 3/8] netdev-offload-tc: Introduce group ID management API

2023-03-19 Thread Chris Mi via dev
On 3/16/2023 5:09 PM, Eelco Chaudron wrote: On 1 Mar 2023, at 8:22, Chris Mi wrote: When offloading sample action to TC, userspace creates a unique ID to map sFlow action and tunnel info and passes this ID to kernel instead of the sFlow info. Psample will send this ID and sampled packet to

Re: [ovs-dev] [PATCH v24 3/8] netdev-offload-tc: Introduce group ID management API

2023-03-16 Thread Eelco Chaudron
On 1 Mar 2023, at 8:22, Chris Mi wrote: > When offloading sample action to TC, userspace creates a unique ID > to map sFlow action and tunnel info and passes this ID to kernel > instead of the sFlow info. Psample will send this ID and sampled > packet to userspace. Using the ID, userspace can

[ovs-dev] [PATCH v24 3/8] netdev-offload-tc: Introduce group ID management API

2023-02-28 Thread Chris Mi via dev
When offloading sample action to TC, userspace creates a unique ID to map sFlow action and tunnel info and passes this ID to kernel instead of the sFlow info. Psample will send this ID and sampled packet to userspace. Using the ID, userspace can recover the sFlow info and send sampled packet to