Re: [ovs-dev] [PATCH v3] Upcall/Slowpath rate limiter for OVS

Jan, Thanx for your comments. Please see inline. I will send v4 patch with your comments addressed. Thanx Manu On 09/05/18, 5:26 AM, "Jan Scheurich" wrote: Hi Manu, Thanks for working on this. Two general comments: 1. Is there a chance to

Re: [ovs-dev] [PATCH v3] Upcall/Slowpath rate limiter for OVS

Hi Manu, Thanks for working on this. Two general comments: 1. Is there a chance to add unit test cases for this feature? I know it might be difficult due to the real-time character, but perhaps using very low parameter values? 2. I believe the number RL-dropped packets must be accounted for

[ovs-dev] [PATCH v3] Upcall/Slowpath rate limiter for OVS

Hi Rebased to master and adapted to the new dpif-netdev-perf counters. As explained in v2 thread, OFPM_SLOWPATH meters cannot be used as is for rate-limiting upcalls, hence reverted back to the simpler method using token bucket. Could you please review this patch? Thanx Manu v2: