Re: [ovs-dev] [PATCH v3] netdev: Retry getting interfaces on inconsistent dumps from kernel

2018-11-16 Thread Daniel Alvarez Sanchez
I forgot about this, sorry. Just sent the patch with the comment. Thanks a lot, Daniel On Sat, Aug 18, 2018 at 5:41 PM Ben Pfaff wrote: > > On August 18, 2018 8:18:51 AM PDT, Daniel Alvarez Sanchez > wrote: >> >> Thanks a lot Ben. >> It was fixed in glibc 2.28. Shall I send a patch to add the

Re: [ovs-dev] [PATCH v3] netdev: Retry getting interfaces on inconsistent dumps from kernel

2018-08-18 Thread Ben Pfaff
On August 18, 2018 8:18:51 AM PDT, Daniel Alvarez Sanchez wrote: >Thanks a lot Ben. >It was fixed in glibc 2.28. Shall I send a patch to add the comment in >the >code? I think it's a good idea so that we can remove the workaround >eventually. Not sure about sending a patch for just a comment

Re: [ovs-dev] [PATCH v3] netdev: Retry getting interfaces on inconsistent dumps from kernel

2018-08-18 Thread Daniel Alvarez Sanchez
Thanks a lot Ben. It was fixed in glibc 2.28. Shall I send a patch to add the comment in the code? I think it's a good idea so that we can remove the workaround eventually. Not sure about sending a patch for just a comment though :) On Wed, Aug 15, 2018 at 10:40 PM Ben Pfaff wrote: > On Mon,

Re: [ovs-dev] [PATCH v3] netdev: Retry getting interfaces on inconsistent dumps from kernel

2018-08-15 Thread Ben Pfaff
On Mon, Aug 13, 2018 at 05:39:07PM -0700, Ben Pfaff wrote: > On Mon, Aug 13, 2018 at 02:07:45PM +0200, Daniel Alvarez wrote: > > This patch in glibc [0] is fixing a bug where we may be getting > > inconsistent dumps from the kernel when listing interfaces due to > > a race condition. > > > > This

Re: [ovs-dev] [PATCH v3] netdev: Retry getting interfaces on inconsistent dumps from kernel

2018-08-13 Thread Ben Pfaff
On Mon, Aug 13, 2018 at 05:39:07PM -0700, Ben Pfaff wrote: > On Mon, Aug 13, 2018 at 02:07:45PM +0200, Daniel Alvarez wrote: > > This patch in glibc [0] is fixing a bug where we may be getting > > inconsistent dumps from the kernel when listing interfaces due to > > a race condition. > > > > This

Re: [ovs-dev] [PATCH v3] netdev: Retry getting interfaces on inconsistent dumps from kernel

2018-08-13 Thread Ben Pfaff
On Mon, Aug 13, 2018 at 02:07:45PM +0200, Daniel Alvarez wrote: > This patch in glibc [0] is fixing a bug where we may be getting > inconsistent dumps from the kernel when listing interfaces due to > a race condition. > > This could happen if we try to retrieve them while interfaces are > being

[ovs-dev] [PATCH v3] netdev: Retry getting interfaces on inconsistent dumps from kernel

2018-08-13 Thread Daniel Alvarez
This patch in glibc [0] is fixing a bug where we may be getting inconsistent dumps from the kernel when listing interfaces due to a race condition. This could happen if we try to retrieve them while interfaces are being added/removed from the system at the same time. For systems running against