Re: [ovs-dev] [PATCH v3] tests: Add OVS-DPDK MTU unit tests.

2022-07-12 Thread Amber, Kumar
> > Hi Michael, > > > > The patch uses MTU sizes > 9000 values to check and fail but 9000 may > > not be good value for older NICs As they might fail the test ? > > > > Can we kind of confirm is MTU > 9000 is safe if not we can just use a > > lower value like 1500 etc etc to be safe So that we

Re: [ovs-dev] [PATCH v3] tests: Add OVS-DPDK MTU unit tests.

2022-07-12 Thread Stokes, Ian
> Hi Michael, > > The patch uses MTU sizes > 9000 values to check and fail but 9000 may not > be good value for older NICs > As they might fail the test ? > > Can we kind of confirm is MTU > 9000 is safe if not we can just use a lower > value like 1500 etc etc to be safe > So that we don't

Re: [ovs-dev] [PATCH v3] tests: Add OVS-DPDK MTU unit tests.

2022-07-12 Thread Amber, Kumar
Hi Michael, The patch uses MTU sizes > 9000 values to check and fail but 9000 may not be good value for older NICs As they might fail the test ? Can we kind of confirm is MTU > 9000 is safe if not we can just use a lower value like 1500 etc etc to be safe So that we don't fail un-necessary

Re: [ovs-dev] [PATCH v3] tests: Add OVS-DPDK MTU unit tests.

2022-07-11 Thread Pai G, Sunil
Hi Mike, Thanks for reworking the tests. One minor nit inline, otherwise patch LGTM, > -Original Message- > From: Phelan, Michael > Sent: Monday, July 11, 2022 7:19 PM > To: d...@openvswitch.org > Cc: Stokes, Ian ; acon...@redhat.com; > i.maxim...@ovn.org; maxime.coque...@redhat.com;

[ovs-dev] [PATCH v3] tests: Add OVS-DPDK MTU unit tests.

2022-07-11 Thread Michael Phelan
This adds 8 new unit tests to the 'check-dpdk' subsystem that will test Maximum Transmission Unit (MTU) functionality. Signed-off-by: Michael Phelan Signed-off-by: Sunil Pai G Co-authored-by: Sunil Pai G --- v3: - Capitalize first letter in comments. - Add [] in AT_CHECK commands. -