Re: [ovs-dev] [PATCH v3 05/16] ofp-actions: Add clone action.

2016-12-21 Thread William Tu
thanks. I will submit v4 patch. On Wed, Dec 21, 2016 at 10:46 AM, Joe Stringer wrote: > On 21 December 2016 at 10:28, William Tu wrote: >> sorry, I forgot to add priority. Below lower the priority of the NORMAL >> action. >> >> diff --git a/tests/system-traffic.at b/tests/system-traffic.at >> i

Re: [ovs-dev] [PATCH v3 05/16] ofp-actions: Add clone action.

2016-12-21 Thread Joe Stringer
On 21 December 2016 at 10:28, William Tu wrote: > sorry, I forgot to add priority. Below lower the priority of the NORMAL > action. > > diff --git a/tests/system-traffic.at b/tests/system-traffic.at > index d70c5c3..321a901 100644 > --- a/tests/system-traffic.at > +++ b/tests/system-traffic.at >

Re: [ovs-dev] [PATCH v3 05/16] ofp-actions: Add clone action.

2016-12-21 Thread William Tu
sorry, I forgot to add priority. Below lower the priority of the NORMAL action. diff --git a/tests/system-traffic.at b/tests/system-traffic.at index d70c5c3..321a901 100644 --- a/tests/system-traffic.at +++ b/tests/system-traffic.at @@ -340,6 +340,7 @@ AT_CLEANUP AT_SETUP([datapath - clone action

Re: [ovs-dev] [PATCH v3 05/16] ofp-actions: Add clone action.

2016-12-21 Thread Joe Stringer
On 21 December 2016 at 07:45, William Tu wrote: > Hi Joe, > > I think we're missing the normal action for handling the non-IP > traffic. Can you try this patch on top of the clone? > > --- a/tests/system-traffic.at > +++ b/tests/system-traffic.at > @@ -340,6 +340,7 @@ AT_CLEANUP > AT_SETUP([datap

Re: [ovs-dev] [PATCH v3 05/16] ofp-actions: Add clone action.

2016-12-21 Thread William Tu
Hi Joe, I think we're missing the normal action for handling the non-IP traffic. Can you try this patch on top of the clone? --- a/tests/system-traffic.at +++ b/tests/system-traffic.at @@ -340,6 +340,7 @@ AT_CLEANUP AT_SETUP([datapath - clone action]) OVS_TRAFFIC_VSWITCHD_START() +AT_CHECK([ov

Re: [ovs-dev] [PATCH v3 05/16] ofp-actions: Add clone action.

2016-12-20 Thread William Tu
Hi Joe, Thanks I will take a look. William On Tue, Dec 20, 2016 at 10:25 AM, Joe Stringer wrote: > On 18 December 2016 at 00:18, Ben Pfaff wrote: >> From: William Tu >> >> This patch adds OpenFlow clone action with syntax as below: >> "clone([action][,action...])". The clone() action makes a c

Re: [ovs-dev] [PATCH v3 05/16] ofp-actions: Add clone action.

2016-12-20 Thread Joe Stringer
On 18 December 2016 at 00:18, Ben Pfaff wrote: > From: William Tu > > This patch adds OpenFlow clone action with syntax as below: > "clone([action][,action...])". The clone() action makes a copy of the > current packet and executes the list of actions against the packet, > without affecting the

[ovs-dev] [PATCH v3 05/16] ofp-actions: Add clone action.

2016-12-18 Thread Ben Pfaff
From: William Tu This patch adds OpenFlow clone action with syntax as below: "clone([action][,action...])". The clone() action makes a copy of the current packet and executes the list of actions against the packet, without affecting the packet after the "clone(...)" action. In other word, the p