Re: [ovs-dev] [PATCH v3 1/2] ofproto-dpif-upcall: Reset ukey's last stats value if the datapath changed.

2023-02-27 Thread Eelco Chaudron
On 21 Feb 2023, at 12:15, Simon Horman wrote: Thanks for the review Simon, see responses inline. Will send out a v4 soon. //Eelco > On Fri, Feb 03, 2023 at 12:12:12PM +0100, Eelco Chaudron wrote: >> When the ukey's action set changes, it could caus the flow to use a > > nit: s/caus/cause/ Wil

Re: [ovs-dev] [PATCH v3 1/2] ofproto-dpif-upcall: Reset ukey's last stats value if the datapath changed.

2023-02-21 Thread Simon Horman
On Fri, Feb 03, 2023 at 12:12:12PM +0100, Eelco Chaudron wrote: > When the ukey's action set changes, it could caus the flow to use a nit: s/caus/cause/ > different datapath, for example, when it moves from tc to kernel. > This will cause the the cached previous datapath statistics to be used. >

[ovs-dev] [PATCH v3 1/2] ofproto-dpif-upcall: Reset ukey's last stats value if the datapath changed.

2023-02-03 Thread Eelco Chaudron
When the ukey's action set changes, it could caus the flow to use a different datapath, for example, when it moves from tc to kernel. This will cause the the cached previous datapath statistics to be used. This change will reset the cached statistics when a change in datapath is discovered. Signe