Re: [ovs-dev] [PATCH v3 1/2] ofproto-ipfix: use per-domain template timeouts

2023-02-21 Thread Ilya Maximets
On 2/20/23 16:41, Simon Horman wrote: > On Fri, Feb 10, 2023 at 05:03:13PM +0100, Adrián Moreno wrote: >> From: Adrian Moreno >> >> IPFIX templates have to be sent for each Observation Domain ID. >> Currently, a timer is kept at each dpif_ipfix_exporter to send them. >> This works fine for

Re: [ovs-dev] [PATCH v3 1/2] ofproto-ipfix: use per-domain template timeouts

2023-02-20 Thread Simon Horman
On Fri, Feb 10, 2023 at 05:03:13PM +0100, Adrián Moreno wrote: > From: Adrian Moreno > > IPFIX templates have to be sent for each Observation Domain ID. > Currently, a timer is kept at each dpif_ipfix_exporter to send them. > This works fine for per-bridge sampling where there is only one >

Re: [ovs-dev] [PATCH v3 1/2] ofproto-ipfix: use per-domain template timeouts

2023-02-13 Thread 0-day Robot
Bleep bloop. Greetings Adrián Moreno, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Comment with 'xxx' marker #271 FILE: ofproto/ofproto-dpif-ipfix.c:2925: /*

[ovs-dev] [PATCH v3 1/2] ofproto-ipfix: use per-domain template timeouts

2023-02-10 Thread Adrián Moreno
From: Adrian Moreno IPFIX templates have to be sent for each Observation Domain ID. Currently, a timer is kept at each dpif_ipfix_exporter to send them. This works fine for per-bridge sampling where there is only one Observation Domain ID per exporter. However, this is does not work for per-flow