On 2020/07/28 3:14, William Tu wrote:
On Sun, Jul 26, 2020 at 9:55 AM Toshiaki Makita
wrote:
snip
How about doing s.t like:
--enable-afxdp: the current one on master without the xdp offload program
--enable-afxdp-with-bpf: the afxdp one plus your xdp offload program
So that when users
On Sun, Jul 26, 2020 at 9:55 AM Toshiaki Makita
wrote:
>
snip
> >> How about doing s.t like:
> >> --enable-afxdp: the current one on master without the xdp offload program
> >> --enable-afxdp-with-bpf: the afxdp one plus your xdp offload program
> >>
> >> So that when users only --enable-afxdp,
William,
On 2020/07/22 17:46, Toshiaki Makita wrote:
On 2020/07/22 3:10, William Tu wrote:
Thanks for the patch. My comments below:
On Mon, Jun 29, 2020 at 8:30 AM Toshiaki Makita
wrote:
...
diff --git a/lib/automake.mk b/lib/automake.mk
index 86940ccd2..1fa1371f3 100644
---
On 2020/07/22 3:10, William Tu wrote:
Thanks for the patch. My comments below:
On Mon, Jun 29, 2020 at 8:30 AM Toshiaki Makita
wrote:
This provider offloads classifier to software XDP.
It works only when a custom XDP object is loaded by afxdp netdev.
The BPF program needs to implement
On 2020/07/22 0:34, William Tu wrote:
On Tue, Jul 7, 2020 at 2:07 AM Toshiaki Makita
wrote:
On 2020/06/30 0:30, Toshiaki Makita wrote:
...
int netdev_afxdp_init(void)
{
libbpf_set_print(libbpf_print);
-return 0;
+return netdev_register_flow_api_provider(_offload_xdp);
On 2020/07/22 0:38, Aaron Conole wrote:
William Tu writes:
On Tue, Jun 30, 2020 at 12:11 AM Toshiaki Makita
wrote:
On 2020/06/30 1:17, 0-day Robot wrote:
Bleep bloop. Greetings Toshiaki Makita, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered
Thanks for the patch. My comments below:
On Mon, Jun 29, 2020 at 8:30 AM Toshiaki Makita
wrote:
>
> This provider offloads classifier to software XDP.
>
> It works only when a custom XDP object is loaded by afxdp netdev.
> The BPF program needs to implement classifier with array-of-maps for
>
William Tu writes:
> On Tue, Jun 30, 2020 at 12:11 AM Toshiaki Makita
> wrote:
>>
>> On 2020/06/30 1:17, 0-day Robot wrote:
>> > Bleep bloop. Greetings Toshiaki Makita, I am a robot and I have tried out
>> > your patch.
>> > Thanks for your contribution.
>> >
>> > I encountered some error
On Tue, Jul 7, 2020 at 2:07 AM Toshiaki Makita
wrote:
>
> On 2020/06/30 0:30, Toshiaki Makita wrote:
> ...
> > int netdev_afxdp_init(void)
> > {
> > libbpf_set_print(libbpf_print);
> > -return 0;
> > +return netdev_register_flow_api_provider(_offload_xdp);
>
> This causes
On Tue, Jun 30, 2020 at 12:11 AM Toshiaki Makita
wrote:
>
> On 2020/06/30 1:17, 0-day Robot wrote:
> > Bleep bloop. Greetings Toshiaki Makita, I am a robot and I have tried out
> > your patch.
> > Thanks for your contribution.
> >
> > I encountered some error that I wasn't expecting. See the
On 2020/06/30 0:30, Toshiaki Makita wrote:
...
int netdev_afxdp_init(void)
{
libbpf_set_print(libbpf_print);
-return 0;
+return netdev_register_flow_api_provider(_offload_xdp);
This causes duplicate flow api provider error because afxdp and afxdp-nonpmd
are using
the same
On 2020/06/30 1:17, 0-day Robot wrote:
Bleep bloop. Greetings Toshiaki Makita, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Comment with 'xxx' marker
#252 FILE:
Bleep bloop. Greetings Toshiaki Makita, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Comment with 'xxx' marker
#252 FILE: lib/netdev-afxdp.c:329:
/* XXX: close
This provider offloads classifier to software XDP.
It works only when a custom XDP object is loaded by afxdp netdev.
The BPF program needs to implement classifier with array-of-maps for
subtable hashmaps and arraymap for subtable masks. The flow api
provider detects classifier support in the
14 matches
Mail list logo
