Re: [ovs-dev] [PATCH v3 ovn] controller: reconfigure ovs meters for ovn meters updates

2022-02-17 Thread Mark Michelson
Hi Lorenzo, I think this is an improvement over the previous version, but there are still issues that need addressing. The problem with adding meter incremental processing is that there doesn't exist any unconditional processing of the SB meter data. In other words, there is no place in the

Re: [ovs-dev] [PATCH v3 ovn] controller: reconfigure ovs meters for ovn meters updates

2022-02-10 Thread 0-day Robot
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Inappropriate bracing around statement #100 FILE: controller/ofctrl.c:1853:

[ovs-dev] [PATCH v3 ovn] controller: reconfigure ovs meters for ovn meters updates

2022-02-10 Thread Lorenzo Bianconi
At the moment ovs meters are reconfigured by ovn just when a new a meter is allocated while updates for an already allocated meter are ignored. This issue can be easily verified with the following reproducer: $ovn-nbctl meter-add meter0 drop 10 pktps $ovn-nbctl --log --meter=meter0 acl-add sw0