Re: [ovs-dev] [PATCH v4] gre: Rename fallback devices to avoid udev's interference

2018-09-17 Thread Gregory Rose
On 9/17/2018 4:34 PM, Yifeng Sun wrote: Hi Greg, Your guess is correct. The FB device is only created once. Even if more tunnels are added, there are still only one FB device. Yes, three digits should be enough in our case. Thanks, Yifeng Excellent!  Thanks for confirming.  I think if you

Re: [ovs-dev] [PATCH v4] gre: Rename fallback devices to avoid udev's interference

2018-09-17 Thread Yifeng Sun
Hi Greg, Your guess is correct. The FB device is only created once. Even if more tunnels are added, there are still only one FB device. Yes, three digits should be enough in our case. Thanks, Yifeng On Mon, Sep 17, 2018 at 2:28 PM Gregory Rose wrote: > On 9/17/2018 1:40 PM, Yifeng Sun wrote:

Re: [ovs-dev] [PATCH v4] gre: Rename fallback devices to avoid udev's interference

2018-09-17 Thread Gregory Rose
On 9/17/2018 1:40 PM, Yifeng Sun wrote: Hi Greg, I checked that the 'else' part in the above patch is actually executed. So it should be necessary to keep them. Thanks, Yifeng That's interesting but I expect that it is only executed once during creation of the FB device.  Does it continue

Re: [ovs-dev] [PATCH v4] gre: Rename fallback devices to avoid udev's interference

2018-09-17 Thread Yifeng Sun
Hi Greg, I checked that the 'else' part in the above patch is actually executed. So it should be necessary to keep them. Thanks, Yifeng On Mon, Sep 17, 2018 at 9:51 AM Yifeng Sun wrote: > Hi Greg, > > Sure, thanks for the review. I will work on it. > > Yifeng > > On Mon, Sep 17, 2018 at 8:49

Re: [ovs-dev] [PATCH v4] gre: Rename fallback devices to avoid udev's interference

2018-09-17 Thread Yifeng Sun
Hi Greg, Sure, thanks for the review. I will work on it. Yifeng On Mon, Sep 17, 2018 at 8:49 AM Gregory Rose wrote: > On 9/15/2018 9:24 PM, Yifeng Sun wrote: > > On certain kernel versions, when openvswitch kernel module creates > > a gre0 interface, the kernel’s gre module will jump out and

Re: [ovs-dev] [PATCH v4] gre: Rename fallback devices to avoid udev's interference

2018-09-17 Thread Gregory Rose
On 9/15/2018 9:24 PM, Yifeng Sun wrote: On certain kernel versions, when openvswitch kernel module creates a gre0 interface, the kernel’s gre module will jump out and compete to control the gre0 interface. This will cause the failure of openvswitch kernel module loading. This fix renames

[ovs-dev] [PATCH v4] gre: Rename fallback devices to avoid udev's interference

2018-09-15 Thread Yifeng Sun
On certain kernel versions, when openvswitch kernel module creates a gre0 interface, the kernel’s gre module will jump out and compete to control the gre0 interface. This will cause the failure of openvswitch kernel module loading. This fix renames fallback devices by adding a prefix "ovs-".