Re: [ovs-dev] [PATCH v4 1/2] Encap & Decap actions for MPLS packet type.

2021-06-21 Thread Eelco Chaudron
On 19 Jun 2021, at 8:06, Martin Varghese wrote: > On Thu, Apr 08, 2021 at 03:31:24PM +0200, Eelco Chaudron wrote: >> >> >> On 8 Apr 2021, at 14:05, Martin Varghese wrote: >> >>> On Wed, Apr 07, 2021 at 03:49:07PM +, Jan Scheurich wrote: Hi Martin, I guess you are aware of the

Re: [ovs-dev] [PATCH v4 1/2] Encap & Decap actions for MPLS packet type.

2021-06-19 Thread Martin Varghese
On Thu, Apr 08, 2021 at 03:31:24PM +0200, Eelco Chaudron wrote: > > > On 8 Apr 2021, at 14:05, Martin Varghese wrote: > > > On Wed, Apr 07, 2021 at 03:49:07PM +, Jan Scheurich wrote: > > > Hi Martin, > > > > > > I guess you are aware of the original design document we wrote for > > >

Re: [ovs-dev] [PATCH v4 1/2] Encap & Decap actions for MPLS packet type.

2021-04-17 Thread Jan Scheurich via dev
> -Original Message- > From: Martin Varghese > Sent: Tuesday, 13 April, 2021 16:20 > To: Jan Scheurich > Cc: Eelco Chaudron ; d...@openvswitch.org; > pshe...@ovn.org; martin.vargh...@nokia.com > Subject: Re: [PATCH v4 1/2] Encap & Decap actions for MPLS packet type. > > On Wed, Apr

Re: [ovs-dev] [PATCH v4 1/2] Encap & Decap actions for MPLS packet type.

2021-04-13 Thread Martin Varghese
On Wed, Apr 07, 2021 at 03:49:07PM +, Jan Scheurich wrote: > Hi Martin, > > I guess you are aware of the original design document we wrote for generic > encap/decap and NSH support: > https://docs.google.com/document/d/1oWMYUH8sjZJzWa72o2q9kU0N6pNE-rwZcLH3-kbbDR8/edit# > > It is no longer

Re: [ovs-dev] [PATCH v4 1/2] Encap & Decap actions for MPLS packet type.

2021-04-08 Thread Eelco Chaudron
On 8 Apr 2021, at 14:05, Martin Varghese wrote: On Wed, Apr 07, 2021 at 03:49:07PM +, Jan Scheurich wrote: Hi Martin, I guess you are aware of the original design document we wrote for generic encap/decap and NSH support:

Re: [ovs-dev] [PATCH v4 1/2] Encap & Decap actions for MPLS packet type.

2021-04-08 Thread Martin Varghese
On Wed, Apr 07, 2021 at 03:49:07PM +, Jan Scheurich wrote: > Hi Martin, > > I guess you are aware of the original design document we wrote for generic > encap/decap and NSH support: > https://docs.google.com/document/d/1oWMYUH8sjZJzWa72o2q9kU0N6pNE-rwZcLH3-kbbDR8/edit# > > It is no longer

Re: [ovs-dev] [PATCH v4 1/2] Encap & Decap actions for MPLS packet type.

2021-04-07 Thread Jan Scheurich via dev
Hi Martin, I guess you are aware of the original design document we wrote for generic encap/decap and NSH support: https://docs.google.com/document/d/1oWMYUH8sjZJzWa72o2q9kU0N6pNE-rwZcLH3-kbbDR8/edit# It is no longer 100% aligned with the final implementation in OVS but still a good reference

Re: [ovs-dev] [PATCH v4 1/2] Encap & Decap actions for MPLS packet type.

2021-04-07 Thread Martin Varghese
On Tue, Apr 06, 2021 at 09:00:16AM +, Jan Scheurich wrote: > Hi, > > Thanks for the heads up. The interaction with MPLS push/pop is a use case > that was likely not tested during the NSH and generic encap/decap design. > It's complex code and a long time ago. I'm willing to help, but I will

Re: [ovs-dev] [PATCH v4 1/2] Encap & Decap actions for MPLS packet type.

2021-04-06 Thread Martin Varghese
On Tue, Apr 06, 2021 at 10:54:32AM +0200, Eelco Chaudron wrote: > > > On 6 Apr 2021, at 10:27, Martin Varghese wrote: > > > On Thu, Apr 01, 2021 at 11:32:06AM +0200, Eelco Chaudron wrote: > > > > > > > > > On 1 Apr 2021, at 11:28, Martin Varghese wrote: > > > > > > > On Thu, Apr 01, 2021 at

Re: [ovs-dev] [PATCH v4 1/2] Encap & Decap actions for MPLS packet type.

2021-04-06 Thread Jan Scheurich via dev
Hi, Thanks for the heads up. The interaction with MPLS push/pop is a use case that was likely not tested during the NSH and generic encap/decap design. It's complex code and a long time ago. I'm willing to help, but I will need some time to go back and have a look. It would definitely help,

Re: [ovs-dev] [PATCH v4 1/2] Encap & Decap actions for MPLS packet type.

2021-04-06 Thread Eelco Chaudron
On 6 Apr 2021, at 10:27, Martin Varghese wrote: On Thu, Apr 01, 2021 at 11:32:06AM +0200, Eelco Chaudron wrote: On 1 Apr 2021, at 11:28, Martin Varghese wrote: On Thu, Apr 01, 2021 at 11:17:14AM +0200, Eelco Chaudron wrote: On 1 Apr 2021, at 11:09, Martin Varghese wrote: On Thu, Apr

Re: [ovs-dev] [PATCH v4 1/2] Encap & Decap actions for MPLS packet type.

2021-04-06 Thread Martin Varghese
On Thu, Apr 01, 2021 at 11:32:06AM +0200, Eelco Chaudron wrote: > > > On 1 Apr 2021, at 11:28, Martin Varghese wrote: > > > On Thu, Apr 01, 2021 at 11:17:14AM +0200, Eelco Chaudron wrote: > > > > > > > > > On 1 Apr 2021, at 11:09, Martin Varghese wrote: > > > > > > > On Thu, Apr 01, 2021 at

Re: [ovs-dev] [PATCH v4 1/2] Encap & Decap actions for MPLS packet type.

2021-04-06 Thread Eelco Chaudron
On 1 Apr 2021, at 11:32, Eelco Chaudron wrote: On 1 Apr 2021, at 11:28, Martin Varghese wrote: On Thu, Apr 01, 2021 at 11:17:14AM +0200, Eelco Chaudron wrote: On 1 Apr 2021, at 11:09, Martin Varghese wrote: On Thu, Apr 01, 2021 at 10:54:42AM +0200, Eelco Chaudron wrote: On 1 Apr

Re: [ovs-dev] [PATCH v4 1/2] Encap & Decap actions for MPLS packet type.

2021-04-01 Thread Eelco Chaudron
On 1 Apr 2021, at 11:28, Martin Varghese wrote: On Thu, Apr 01, 2021 at 11:17:14AM +0200, Eelco Chaudron wrote: On 1 Apr 2021, at 11:09, Martin Varghese wrote: On Thu, Apr 01, 2021 at 10:54:42AM +0200, Eelco Chaudron wrote: On 1 Apr 2021, at 10:35, Martin Varghese wrote: On Thu, Apr

Re: [ovs-dev] [PATCH v4 1/2] Encap & Decap actions for MPLS packet type.

2021-04-01 Thread Martin Varghese
On Thu, Apr 01, 2021 at 11:17:14AM +0200, Eelco Chaudron wrote: > > > On 1 Apr 2021, at 11:09, Martin Varghese wrote: > > > On Thu, Apr 01, 2021 at 10:54:42AM +0200, Eelco Chaudron wrote: > > > > > > > > > On 1 Apr 2021, at 10:35, Martin Varghese wrote: > > > > > > > On Thu, Apr 01, 2021 at

Re: [ovs-dev] [PATCH v4 1/2] Encap & Decap actions for MPLS packet type.

2021-04-01 Thread Eelco Chaudron
On 1 Apr 2021, at 11:17, Eelco Chaudron wrote: On 1 Apr 2021, at 11:09, Martin Varghese wrote: On Thu, Apr 01, 2021 at 10:54:42AM +0200, Eelco Chaudron wrote: On 1 Apr 2021, at 10:35, Martin Varghese wrote: On Thu, Apr 01, 2021 at 08:59:27AM +0200, Eelco Chaudron wrote: On 1 Apr

Re: [ovs-dev] [PATCH v4 1/2] Encap & Decap actions for MPLS packet type.

2021-04-01 Thread Eelco Chaudron
On 1 Apr 2021, at 11:09, Martin Varghese wrote: On Thu, Apr 01, 2021 at 10:54:42AM +0200, Eelco Chaudron wrote: On 1 Apr 2021, at 10:35, Martin Varghese wrote: On Thu, Apr 01, 2021 at 08:59:27AM +0200, Eelco Chaudron wrote: On 1 Apr 2021, at 6:10, Martin Varghese wrote: On Wed, Mar

Re: [ovs-dev] [PATCH v4 1/2] Encap & Decap actions for MPLS packet type.

2021-04-01 Thread Martin Varghese
On Thu, Apr 01, 2021 at 10:54:42AM +0200, Eelco Chaudron wrote: > > > On 1 Apr 2021, at 10:35, Martin Varghese wrote: > > > On Thu, Apr 01, 2021 at 08:59:27AM +0200, Eelco Chaudron wrote: > > > > > > > > > On 1 Apr 2021, at 6:10, Martin Varghese wrote: > > > > > > > On Wed, Mar 31, 2021 at

Re: [ovs-dev] [PATCH v4 1/2] Encap & Decap actions for MPLS packet type.

2021-04-01 Thread Eelco Chaudron
On 1 Apr 2021, at 10:35, Martin Varghese wrote: On Thu, Apr 01, 2021 at 08:59:27AM +0200, Eelco Chaudron wrote: On 1 Apr 2021, at 6:10, Martin Varghese wrote: On Wed, Mar 31, 2021 at 03:59:40PM +0200, Eelco Chaudron wrote: On 26 Mar 2021, at 7:21, Martin Varghese wrote: From: Martin

Re: [ovs-dev] [PATCH v4 1/2] Encap & Decap actions for MPLS packet type.

2021-04-01 Thread Martin Varghese
On Thu, Apr 01, 2021 at 08:59:27AM +0200, Eelco Chaudron wrote: > > > On 1 Apr 2021, at 6:10, Martin Varghese wrote: > > > On Wed, Mar 31, 2021 at 03:59:40PM +0200, Eelco Chaudron wrote: > > > > > > > > > On 26 Mar 2021, at 7:21, Martin Varghese wrote: > > > > > > > From: Martin Varghese >

Re: [ovs-dev] [PATCH v4 1/2] Encap & Decap actions for MPLS packet type.

2021-04-01 Thread Eelco Chaudron
On 1 Apr 2021, at 8:59, Eelco Chaudron wrote: On 1 Apr 2021, at 6:10, Martin Varghese wrote: On Wed, Mar 31, 2021 at 03:59:40PM +0200, Eelco Chaudron wrote: On 26 Mar 2021, at 7:21, Martin Varghese wrote: From: Martin Varghese The encap & decap actions are extended to support MPLS

Re: [ovs-dev] [PATCH v4 1/2] Encap & Decap actions for MPLS packet type.

2021-04-01 Thread Eelco Chaudron
On 1 Apr 2021, at 6:10, Martin Varghese wrote: On Wed, Mar 31, 2021 at 03:59:40PM +0200, Eelco Chaudron wrote: On 26 Mar 2021, at 7:21, Martin Varghese wrote: From: Martin Varghese The encap & decap actions are extended to support MPLS packet type. Encap & decap actions adds and

Re: [ovs-dev] [PATCH v4 1/2] Encap & Decap actions for MPLS packet type.

2021-03-31 Thread Martin Varghese
On Wed, Mar 31, 2021 at 03:59:40PM +0200, Eelco Chaudron wrote: > > > On 26 Mar 2021, at 7:21, Martin Varghese wrote: > > > From: Martin Varghese > > > > The encap & decap actions are extended to support MPLS packet type. > > Encap & decap actions adds and removes MPLS header at start of the

Re: [ovs-dev] [PATCH v4 1/2] Encap & Decap actions for MPLS packet type.

2021-03-31 Thread Eelco Chaudron
On 26 Mar 2021, at 7:21, Martin Varghese wrote: From: Martin Varghese The encap & decap actions are extended to support MPLS packet type. Encap & decap actions adds and removes MPLS header at start of the packet. Hi Martin, I’m trying to do some real-life testing, and I’m running into

[ovs-dev] [PATCH v4 1/2] Encap & Decap actions for MPLS packet type.

2021-03-26 Thread Martin Varghese
From: Martin Varghese The encap & decap actions are extended to support MPLS packet type. Encap & decap actions adds and removes MPLS header at start of the packet. Signed-off-by: Martin Varghese --- NEWS | 2 +-