Re: [ovs-dev] [PATCH v4 3/3] netdev-dpdk: Enable vhost-tx-retries config.

2019-07-04 Thread Ilya Maximets
On 04.07.2019 16:59, Ian Stokes wrote: > On 7/4/2019 12:15 PM, Ilya Maximets wrote: >> Few comments inline. >> Probably, could be fixed while applying the patch. > > Ok, these look reasonable to me. I can apply them this evening before > committing. > > If I add these will I had an ACK for you

Re: [ovs-dev] [PATCH v4 3/3] netdev-dpdk: Enable vhost-tx-retries config.

2019-07-04 Thread Ian Stokes
On 7/4/2019 12:15 PM, Ilya Maximets wrote: Few comments inline. Probably, could be fixed while applying the patch. Ok, these look reasonable to me. I can apply them this evening before committing. If I add these will I had an ACK for you Ilya? Regards Ian On 02.07.2019 3:32, Kevin

Re: [ovs-dev] [PATCH v4 3/3] netdev-dpdk: Enable vhost-tx-retries config.

2019-07-04 Thread Ilya Maximets
Few comments inline. Probably, could be fixed while applying the patch. On 02.07.2019 3:32, Kevin Traynor wrote: > vhost tx retries can provide some mitigation against > dropped packets due to a temporarily slow guest/limited queue > size for an interface, but on the other hand when a system > is

Re: [ovs-dev] [PATCH v4 3/3] netdev-dpdk: Enable vhost-tx-retries config.

2019-07-04 Thread Eelco Chaudron
On 3 Jul 2019, at 18:07, Ian Stokes wrote: On 7/2/2019 1:32 AM, Kevin Traynor wrote: vhost tx retries can provide some mitigation against dropped packets due to a temporarily slow guest/limited queue size for an interface, but on the other hand when a system is fully loaded those extra

Re: [ovs-dev] [PATCH v4 3/3] netdev-dpdk: Enable vhost-tx-retries config.

2019-07-03 Thread Ian Stokes
On 7/2/2019 1:32 AM, Kevin Traynor wrote: vhost tx retries can provide some mitigation against dropped packets due to a temporarily slow guest/limited queue size for an interface, but on the other hand when a system is fully loaded those extra cycles retrying could mean packets are dropped

[ovs-dev] [PATCH v4 3/3] netdev-dpdk: Enable vhost-tx-retries config.

2019-07-01 Thread Kevin Traynor
vhost tx retries can provide some mitigation against dropped packets due to a temporarily slow guest/limited queue size for an interface, but on the other hand when a system is fully loaded those extra cycles retrying could mean packets are dropped elsewhere. Up to now max vhost tx retries have