Re: [ovs-dev] [PATCH v5] lib, ovsdb, ovs-vsctl, vtep-ctl: Fix multiple Coverity defects

2023-03-28 Thread James R T
On Mon, Mar 27, 2023 at 5:03 PM Eelco Chaudron wrote: > > I did not review this, but I noticed you do null checks for memset() and > memcpy(). But there are functions for this in OVS like nullable_memset() and > nullable_memcpy(), maybe some of the changes might benefit from using this. > > In

Re: [ovs-dev] [PATCH v5] lib, ovsdb, ovs-vsctl, vtep-ctl: Fix multiple Coverity defects

2023-03-28 Thread Ilya Maximets
On 3/27/23 11:03, Eelco Chaudron wrote: > > > On 16 Mar 2023, at 17:36, James Raphael Tiovalen wrote: > >> This commit addresses several high and medium-impact Coverity defects by >> fixing several possible null-pointer dereferences and potentially >> uninitialized variables. >> >> There were

Re: [ovs-dev] [PATCH v5] lib, ovsdb, ovs-vsctl, vtep-ctl: Fix multiple Coverity defects

2023-03-27 Thread Eelco Chaudron
On 16 Mar 2023, at 17:36, James Raphael Tiovalen wrote: > This commit addresses several high and medium-impact Coverity defects by > fixing several possible null-pointer dereferences and potentially > uninitialized variables. > > There were cases when crashes were encountered when some null

Re: [ovs-dev] [PATCH v5] lib, ovsdb, ovs-vsctl, vtep-ctl: Fix multiple Coverity defects

2023-03-27 Thread James R T
Hi folks, Anything that I can do to move this patch forward? I did consider splitting this patch up into smaller chunks, but I am not sure if it would be helpful since the main changes in this patch are mostly similar, just spread across multiple functions and files. That said, if it would make

[ovs-dev] [PATCH v5] lib, ovsdb, ovs-vsctl, vtep-ctl: Fix multiple Coverity defects

2023-03-16 Thread James Raphael Tiovalen
This commit addresses several high and medium-impact Coverity defects by fixing several possible null-pointer dereferences and potentially uninitialized variables. There were cases when crashes were encountered when some null pointers were dereferenced. Null pointer checks and alternative code