Re: [ovs-dev] [PATCH v5 1/3] netdev-dpdk: Add shared mempool config.

2022-07-11 Thread Pai G, Sunil
Hi Kevin, Responses inline. > > > +static struct user_mempool_config *user_mempools = NULL; static int > > > +n_user_mempools; > > > > Should we consider restricting n_user_mempools to some max value ? > > > > We could do. There is no issue with having many values, it just might not > make

Re: [ovs-dev] [PATCH v5 1/3] netdev-dpdk: Add shared mempool config.

2022-07-11 Thread Kevin Traynor
On Fri, Jul 8, 2022 at 10:18 PM Pai G, Sunil wrote: > > Hi Kevin, > Hi Sunil, thanks for reviewing the patches. > Thanks for the patch. > LGTM in general, couple of minor comments/thoughts inline. > > > > > +struct user_mempool_config { > > +int adj_mtu; > > +int socket_id; > > +}; >

Re: [ovs-dev] [PATCH v5 1/3] netdev-dpdk: Add shared mempool config.

2022-07-08 Thread Pai G, Sunil
Hi Kevin, Thanks for the patch. LGTM in general, couple of minor comments/thoughts inline. > +struct user_mempool_config { > +int adj_mtu; > +int socket_id; > +}; > + > +static struct user_mempool_config *user_mempools = NULL; static int > +n_user_mempools; Should we consider

[ovs-dev] [PATCH v5 1/3] netdev-dpdk: Add shared mempool config.

2022-06-24 Thread Kevin Traynor
Mempools may currently be shared between DPDK ports based on port MTU and NUMA. With some hint from the user we can increase the sharing on MTU and hence reduce memory consumption in many cases. For example, a port with MTU 9000, uses a mempool with an mbuf size based on 9000 MTU. A port with MTU