Re: [ovs-dev] [PATCH v5 1/5] dpif-netdev: associate flow with a mark id

2018-01-29 Thread Finn Christensen
Hi Yuanhan, This will not break our PMD. I think PMDs should be able to handle rss_conf == NULL and then failover to default or initially set rss_conf. Finn >-Original Message- >From: Yuanhan Liu [mailto:y...@fridaylinux.org] >Sent: 29. januar 2018 07:59 >To: Stokes, Ian

Re: [ovs-dev] [PATCH v5 1/5] dpif-netdev: associate flow with a mark id

2018-01-26 Thread Yuanhan Liu
On Fri, Jan 26, 2018 at 10:49:46AM +, Stokes, Ian wrote: > > > > +static int > > > > +mark_to_flow_disassociate(struct dp_netdev_pmd_thread *pmd, > > > > + struct dp_netdev_flow *flow) { > > > > +int ret = 0; > > > > +uint32_t mark = flow->mark; > > > > +

Re: [ovs-dev] [PATCH v5 1/5] dpif-netdev: associate flow with a mark id

2018-01-26 Thread Stokes, Ian
> -Original Message- > From: Yuanhan Liu [mailto:y...@fridaylinux.org] > Sent: Friday, January 26, 2018 8:20 AM > To: Stokes, Ian > Cc: d...@openvswitch.org; Finn Christensen ; Darrell Ball > ; Chandran, Sugesh

Re: [ovs-dev] [PATCH v5 1/5] dpif-netdev: associate flow with a mark id

2018-01-26 Thread Yuanhan Liu
On Wed, Jan 24, 2018 at 05:29:45PM +, Stokes, Ian wrote: > > Meanwhile, the mark to flow mapping becomes to 1:N mapping. That is what > > Is this 1:N or 1:1? I thought I spotted below that it's 1:1. If you look further, you will also spot "1:N". mark to mega flow is 1:1 mark to flow is 1:N

Re: [ovs-dev] [PATCH v5 1/5] dpif-netdev: associate flow with a mark id

2018-01-25 Thread Yuanhan Liu
On Wed, Jan 24, 2018 at 05:29:45PM +, Stokes, Ian wrote: > > -Original Message- > > From: Yuanhan Liu [mailto:y...@fridaylinux.org] > > Sent: Wednesday, December 20, 2017 2:45 PM > > To: d...@openvswitch.org > > Cc: Finn Christensen ; Darrell Ball ;

Re: [ovs-dev] [PATCH v5 1/5] dpif-netdev: associate flow with a mark id

2018-01-24 Thread Stokes, Ian
> -Original Message- > From: Yuanhan Liu [mailto:y...@fridaylinux.org] > Sent: Wednesday, December 20, 2017 2:45 PM > To: d...@openvswitch.org > Cc: Finn Christensen ; Darrell Ball ; > Chandran, Sugesh ; Simon Horman >

[ovs-dev] [PATCH v5 1/5] dpif-netdev: associate flow with a mark id

2017-12-20 Thread Yuanhan Liu
Most modern NICs have the ability to bind a flow with a mark, so that every pkt matches such flow will have that mark present in its desc. The basic idea of doing that is, when we receives pkts later, we could directly get the flow from the mark. That could avoid some very costly CPU operations,