Re: [ovs-dev] [PATCH v5 2/2] Match: Do not print "igmp" match keyword

2021-11-17 Thread Mike Pattrick
No, you have made the good point here. Patch looks good. Acked-by: Mike Pattrick On Wed, Nov 17, 2021 at 11:28 AM Salvatore Daniele wrote: > > Hi Mike, > > Good point. I believe this was discussed previously when this parsing > issue was first addressed [1]. > > IIUC the reasoning is that igmp

Re: [ovs-dev] [PATCH v5 2/2] Match: Do not print "igmp" match keyword

2021-11-17 Thread Salvatore Daniele
Hi Mike, Good point. I believe this was discussed previously when this parsing issue was first addressed [1]. IIUC the reasoning is that igmp fields are not supported by OpenFlow, and other similar protocols like lldp do not print special keyword fields. It would be more consistent with OF/lldp i

Re: [ovs-dev] [PATCH v5 2/2] Match: Do not print "igmp" match keyword

2021-11-17 Thread Mike Pattrick
Hello Salvatore, Why remove support for printing igmp instead of adding support for parsing igmp? -M On Thu, Nov 4, 2021 at 3:40 PM Salvatore Daniele wrote: > > From: Adrian Moreno > > The match keyword "igmp" is not supported in ofp-parse, which means > that flow dumps cannot be restored. Pr

[ovs-dev] [PATCH v5 2/2] Match: Do not print "igmp" match keyword

2021-11-04 Thread Salvatore Daniele
From: Adrian Moreno The match keyword "igmp" is not supported in ofp-parse, which means that flow dumps cannot be restored. Previously a workaround was added to ovs-save to avoid changing output in stable branches. This patch changes the output to print igmp match in the accepted ofp-parse forma