Re: [ovs-dev] [PATCH v6] netdev-offload-tc: del ufid mapping if device not exist

2023-02-23 Thread Simon Horman
On Thu, Feb 23, 2023 at 10:24:54AM +0800, Faicker Mo wrote: > I can run the fail-test more easier. > There exists a flow in verbose log like this, > recirc_id(0),in_port(2),eth(src=aa:1a:54:e9:c5:56,dst=86:29:2a:05:94:90),eth_type(0x0800),ipv4(frag=no), > packets:1, bytes:84, used:12.240s,

Re: [ovs-dev] [PATCH v6] netdev-offload-tc: del ufid mapping if device not exist

2023-02-22 Thread Faicker Mo
v6] netdev-offload-tc: del ufid mapping if device not exist>On Wed, Feb 22, 2023 at 04:19:37PM +0100, Simon Horman wrote: >> On Wed, Feb 22, 2023 at 06:33:50PM +0800, Faicker Mo wrote: >> > It's not easy to add a fail test without the changed code. >> > But I test

Re: [ovs-dev] [PATCH v6] netdev-offload-tc: del ufid mapping if device not exist

2023-02-22 Thread Simon Horman
On Wed, Feb 22, 2023 at 04:19:37PM +0100, Simon Horman wrote: > On Wed, Feb 22, 2023 at 06:33:50PM +0800, Faicker Mo wrote: > > It's not easy to add a fail test without the changed code. > > But I test it failed with the old code manually following these steps, > > 1. Apply this patch(with test in

Re: [ovs-dev] [PATCH v6] netdev-offload-tc: del ufid mapping if device not exist

2023-02-22 Thread Simon Horman
On Wed, Feb 22, 2023 at 06:33:50PM +0800, Faicker Mo wrote: > It's not easy to add a fail test without the changed code. > But I test it failed with the old code manually following these steps, > 1. Apply this patch(with test in it) > 2. Revert the changed code in netdev-offload-tc.c > 3. Run the

Re: [ovs-dev] [PATCH v6] netdev-offload-tc: del ufid mapping if device not exist

2023-02-22 Thread Faicker Mo
and the chance.Maybe run the fail-test several times. From: Simon Horman Date: 2023-02-22 17:07:18 To: Faicker Mo Cc: d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH v6] netdev-offload-tc: del ufid mapping if device not exist>On Wed, Feb 22, 2023 at 10:03:07AM +0800, Faicker Mo wr

Re: [ovs-dev] [PATCH v6] netdev-offload-tc: del ufid mapping if device not exist

2023-02-22 Thread Simon Horman
mailing list. And could you please look at my comment regarding the test you have added in this patch. Thanks! > From: Simon Horman > Date: 2023-02-21 23:09:05 > To: Faicker Mo > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v6] netdev-offload-tc: del ufid mapping if

Re: [ovs-dev] [PATCH v6] netdev-offload-tc: del ufid mapping if device not exist

2023-02-21 Thread Faicker Mo
Sorry. The commit message and code are not changed. Resended when I met a bug of intel-ovs-compilation test fail and add version descriptions. From: Simon Horman Date: 2023-02-21 23:09:05 To: Faicker Mo Cc: d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH v6] netdev-offload-tc: del

Re: [ovs-dev] [PATCH v6] netdev-offload-tc: del ufid mapping if device not exist

2023-02-21 Thread Simon Horman
On Wed, Feb 01, 2023 at 10:49:22AM +0800, Faicker Mo wrote: > The device may be deleted and added with ifindex changed. > The tc rules on the device will be deleted if the device is deleted. > The func tc_del_filter will fail when flow del. The mapping of > ufid to tc will not be deleted. > The

[ovs-dev] [PATCH v6] netdev-offload-tc: del ufid mapping if device not exist

2023-01-31 Thread Faicker Mo
The device may be deleted and added with ifindex changed. The tc rules on the device will be deleted if the device is deleted. The func tc_del_filter will fail when flow del. The mapping of ufid to tc will not be deleted. The traffic will trigger the same flow(with same ufid) to put to tc on the