Re: [ovs-dev] [PATCH v6 1/7] dpif-netdev: Refactor PMD thread structure for further extension.

2017-12-08 Thread Stokes, Ian
> >On 07/12/17 14:28, Ilya Maximets wrote: > >> Thanks for review, comments inline. > >> > >> On 07.12.2017 15:49, Eelco Chaudron wrote: > >>> On 01/12/17 16:44, Ilya Maximets wrote: > This is preparation for 'struct dp_netdev_pmd_thread' modification > in upcoming commits. Needed to

Re: [ovs-dev] [PATCH v6 1/7] dpif-netdev: Refactor PMD thread structure for further extension.

2017-12-08 Thread Jan Scheurich
Hi Bhanu, Perhaps we can aim at fine-tuning the layout of performance-critical structs once at the end of a release cycle when all development is completed. That way we don't hinder productivity during the release cycle and still won't unnecessarily loose performance. And we should definitely

Re: [ovs-dev] [PATCH v6 1/7] dpif-netdev: Refactor PMD thread structure for further extension.

2017-12-07 Thread Bodireddy, Bhanuprakash
>On 07/12/17 14:28, Ilya Maximets wrote: >> Thanks for review, comments inline. >> >> On 07.12.2017 15:49, Eelco Chaudron wrote: >>> On 01/12/17 16:44, Ilya Maximets wrote: This is preparation for 'struct dp_netdev_pmd_thread' modification in upcoming commits. Needed to avoid reordering

Re: [ovs-dev] [PATCH v6 1/7] dpif-netdev: Refactor PMD thread structure for further extension.

2017-12-07 Thread Eelco Chaudron
On 07/12/17 14:48, Jan Scheurich wrote: -Original Message- From: Ilya Maximets [mailto:i.maxim...@samsung.com] Sent: Thursday, 07 December, 2017 14:28 This is preparation for 'struct dp_netdev_pmd_thread' modification in upcoming commits. Needed to avoid reordering and regrouping while

Re: [ovs-dev] [PATCH v6 1/7] dpif-netdev: Refactor PMD thread structure for further extension.

2017-12-07 Thread Jan Scheurich
> -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Thursday, 07 December, 2017 14:28 > >> This is preparation for 'struct dp_netdev_pmd_thread' modification > >> in upcoming commits. Needed to avoid reordering and regrouping while > >> replacing old and

Re: [ovs-dev] [PATCH v6 1/7] dpif-netdev: Refactor PMD thread structure for further extension.

2017-12-07 Thread Ilya Maximets
Thanks for review, comments inline. On 07.12.2017 15:49, Eelco Chaudron wrote: > On 01/12/17 16:44, Ilya Maximets wrote: >> This is preparation for 'struct dp_netdev_pmd_thread' modification >> in upcoming commits. Needed to avoid reordering and regrouping while >> replacing old and adding new

Re: [ovs-dev] [PATCH v6 1/7] dpif-netdev: Refactor PMD thread structure for further extension.

2017-12-07 Thread Eelco Chaudron
On 01/12/17 16:44, Ilya Maximets wrote: This is preparation for 'struct dp_netdev_pmd_thread' modification in upcoming commits. Needed to avoid reordering and regrouping while replacing old and adding new members. Should this be part of the TX batching set? Anyway, I'm ok if it's not stalling

[ovs-dev] [PATCH v6 1/7] dpif-netdev: Refactor PMD thread structure for further extension.

2017-12-01 Thread Ilya Maximets
This is preparation for 'struct dp_netdev_pmd_thread' modification in upcoming commits. Needed to avoid reordering and regrouping while replacing old and adding new members. Signed-off-by: Bhanuprakash Bodireddy Co-authored-by: Bhanuprakash Bodireddy