Re: [ovs-dev] [PATCH v6 3/5] conntrack: Replace timeout based expiration lists with rculists.

2022-07-10 Thread Paolo Valerio
Paolo Valerio writes: > From: Gaetan Rivet > > This patch aims to replace the expiration lists as, due to the way > they are used, besides being a source of contention, they have a known > issue when used with non-default policies for different zones that > could lead to retaining expired

Re: [ovs-dev] [PATCH v6 3/5] conntrack: Replace timeout based expiration lists with rculists.

2022-07-04 Thread Paolo Valerio
wenxu writes: > At 2022-07-04 16:43:20, "Paolo Valerio" wrote: >>Hello wenxu, >> >>thanks for having a look at it. >> >>wenxu writes: >> >>> Hi Paolo, >>> >>> There are two small question. >>> First the ct_lock lock/unlock as below maybe also can be dropped with this >>> patch ? >>> >>>

Re: [ovs-dev] [PATCH v6 3/5] conntrack: Replace timeout based expiration lists with rculists.

2022-07-04 Thread wenxu
At 2022-07-04 16:43:20, "Paolo Valerio" wrote: >Hello wenxu, > >thanks for having a look at it. > >wenxu writes: > >> Hi Paolo, >> >> There are two small question. >> First the ct_lock lock/unlock as below maybe also can be dropped with this >> patch ? >> >>

Re: [ovs-dev] [PATCH v6 3/5] conntrack: Replace timeout based expiration lists with rculists.

2022-07-04 Thread Paolo Valerio
Hello wenxu, thanks for having a look at it. wenxu writes: > Hi Paolo, > > There are two small question. > First the ct_lock lock/unlock as below maybe also can be dropped with this > patch ? > >ovs_mutex_lock(>ct_lock); > if (!conn_lookup(ct, >key, now, NULL, NULL)) { >

Re: [ovs-dev] [PATCH v6 3/5] conntrack: Replace timeout based expiration lists with rculists.

2022-07-03 Thread wenxu
Hi Paolo, There are two small question. First the ct_lock lock/unlock as below maybe also can be dropped with this patch ? ovs_mutex_lock(>ct_lock); if (!conn_lookup(ct, >key, now, NULL, NULL)) { conn = conn_not_found(ct, pkt, ctx, commit, now, nat_action_info,

[ovs-dev] [PATCH v6 3/5] conntrack: Replace timeout based expiration lists with rculists.

2022-07-01 Thread Paolo Valerio
From: Gaetan Rivet This patch aims to replace the expiration lists as, due to the way they are used, besides being a source of contention, they have a known issue when used with non-default policies for different zones that could lead to retaining expired connections potentially for a long time.