Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-22 Thread Sriram Vatala via dev
Thanks Ilya and Kevin. I will send the updated patch set. Thanks & Regards, Sriram. -Original Message- From: Ilya Maximets Sent: 22 October 2019 16:07 To: Kevin Traynor ; Sriram Vatala ; 'Ilya Maximets' ; ovs-dev@openvswitch.org Cc: 'Stokes, Ian' Subject: Re: [PATCH v9 2/2] netdev-dpd

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-22 Thread Ilya Maximets
On 22.10.2019 12:31, Kevin Traynor wrote: On 22/10/2019 09:25, Sriram Vatala wrote: Hi Ilya & Kevin, Thanks for your suggestions. I am summarizing our discussion, please feel free to correct me, if I am wrong. Hi Sriram, Will share my thought, Ilya may have different view. 1) All custom st

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-22 Thread Kevin Traynor
On 22/10/2019 11:31, Kevin Traynor wrote: > On 22/10/2019 09:25, Sriram Vatala wrote: >> Hi Ilya & Kevin, >> Thanks for your suggestions. I am summarizing our discussion, please feel >> free >> to correct me, if I am wrong. >> > > Hi Sriram, > > Will share my thought, Ilya may have different vi

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-22 Thread Kevin Traynor
On 22/10/2019 09:25, Sriram Vatala wrote: > Hi Ilya & Kevin, > Thanks for your suggestions. I am summarizing our discussion, please feel > free > to correct me, if I am wrong. > Hi Sriram, Will share my thought, Ilya may have different view. > 1) All custom stats calculated in OVS will have t

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-22 Thread Ilya Maximets
On 22.10.2019 10:25, Sriram Vatala wrote: Hi Ilya & Kevin, Thanks for your suggestions. I am summarizing our discussion, please feel free to correct me, if I am wrong. 1) All custom stats calculated in OVS will have the prefix , so that these stats will not intersect with the names of other stat

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-22 Thread Sriram Vatala via dev
Hi Ilya & Kevin, Thanks for your suggestions. I am summarizing our discussion, please feel free to correct me, if I am wrong. 1) All custom stats calculated in OVS will have the prefix , so that these stats will not intersect with the names of other stats (driver/HW etc). 2) The prefix used for

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-21 Thread Kevin Traynor
On 18/10/2019 13:59, Ilya Maximets wrote: > On 16.10.2019 19:48, Kevin Traynor wrote: >> On 16/10/2019 13:16, Ilya Maximets wrote: >>> Hi Kevin, >>> >>> Thanks for review. Some comments inline. >>> >>> On 16.10.2019 12:15, Kevin Traynor wrote: Hi Sriram, Thanks for working on making

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-18 Thread Ilya Maximets
On 16.10.2019 19:48, Kevin Traynor wrote: On 16/10/2019 13:16, Ilya Maximets wrote: Hi Kevin, Thanks for review. Some comments inline. On 16.10.2019 12:15, Kevin Traynor wrote: Hi Sriram, Thanks for working on making more fine grained stats for debugging. As mentioned yesterday, this patch n

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-18 Thread Sriram Vatala via dev
Hi, Thanks Kevin for your suggestion. Ilya, Can you please share your opinion also so that we can arrive at some conclusion on the approach. Thanks & Regards, Sriram. -Original Message- From: Kevin Traynor Sent: 16 October 2019 23:18 To: Ilya Maximets ; Sriram Vatala ; ovs-dev@openvswi

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-16 Thread Ben Pfaff
On Wed, Oct 16, 2019 at 02:16:14PM +0200, Ilya Maximets wrote: > BTW, you will not find any description for statistics provided by the linux > or DPDK drivers. You could only look at the driver code or device spec. I'm not sure the meanings are even consistent. I've heard that different Linux dr

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-16 Thread Kevin Traynor
On 16/10/2019 13:16, Ilya Maximets wrote: > Hi Kevin, > > Thanks for review. Some comments inline. > > On 16.10.2019 12:15, Kevin Traynor wrote: >> Hi Sriram, >> >> Thanks for working on making more fine grained stats for debugging. As >> mentioned yesterday, this patch needs rebase so I just rev

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-16 Thread Sriram Vatala via dev
Hi Kevin & Ilya, Thanks Kevin for reviewing the patch. Response inline. Thanks Ilya for your response. -Original Message- From: Ilya Maximets Sent: 16 October 2019 17:46 To: Kevin Traynor ; Sriram Vatala ; ovs-dev@openvswitch.org; Ilya Maximets Cc: Stokes, Ian Subject: Re: [PATCH v9 2

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-16 Thread Ilya Maximets
Hi Kevin, Thanks for review. Some comments inline. On 16.10.2019 12:15, Kevin Traynor wrote: Hi Sriram, Thanks for working on making more fine grained stats for debugging. As mentioned yesterday, this patch needs rebase so I just reviewed docs and netdev-dpdk.c which applied. Comments below.

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-16 Thread Kevin Traynor
Hi Sriram, Thanks for working on making more fine grained stats for debugging. As mentioned yesterday, this patch needs rebase so I just reviewed docs and netdev-dpdk.c which applied. Comments below. On 21/09/2019 03:40, Sriram Vatala wrote: > OVS may be unable to transmit packets for multiple re

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-14 Thread Sriram Vatala via dev
Hi, Please consider this as gentle remainder and kindly review the patch set. Thanks & Regards, Sriram. -Original Message- From: Sriram Vatala Sent: 11 October 2019 16:58 To: 'ovs-dev@openvswitch.org' ; 'i.maxim...@ovn.org' Subject: RE: [PATCH v9 2/2] netdev-dpdk:Detailed packet drop s

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-11 Thread Sriram Vatala via dev
Hi, Please consider this as a gentle remainder. Thanks & Regards, Sriram. -Original Message- From: Sriram Vatala Sent: 09 October 2019 11:53 To: 'ovs-dev@openvswitch.org' Cc: 'ktray...@redhat.com' ; 'Ilya Maximets' ; 'i.maxim...@ovn.org' Subject: RE: [PATCH v9 2/2] netdev-dpdk:Detaile

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-08 Thread Sriram Vatala via dev
Hi All, Please consider this as a gentle remainder. Thanks & Regards, Sriram. -Original Message- From: Sriram Vatala Sent: 04 October 2019 13:37 To: 'ovs-dev@openvswitch.org' Cc: 'ktray...@redhat.com' ; 'Ilya Maximets' Subject: RE: [PATCH v9 2/2] netdev-dpdk:Detailed packet drop stati

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-04 Thread Sriram Vatala via dev
Hi, Please consider this as a gentle remainder. Thanks & Regards, Sriram. -Original Message- From: Sriram Vatala Sent: 25 September 2019 09:58 To: 'ovs-dev@openvswitch.org' Cc: 'ktray...@redhat.com' ; 'Ilya Maximets' Subject: RE: [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statist

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-09-24 Thread Sriram Vatala via dev
Hi, Addressed comments given in patch v8. Kindly review patch v9. Changes since patch v8 : Rebased my changes on top of Ilya's patch " Reuse vhost function for dpdk ETH custom stats". Patch set 1/2. Addressed comments given in patch v8. Thanks & Regards, Sriram. -Original Message- From:

[ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-09-22 Thread Sriram Vatala via dev
OVS may be unable to transmit packets for multiple reasons and today there is a single counter to track packets dropped due to any of those reasons. The most common reason is that a VM is unable to read packets fast enough causing the vhostuser port transmit queue on the OVS side to become full. Th