Re: [ovs-dev] [PATCHv7] netdev-afxdp: add new netdev type for AF_XDP.

2019-05-08 Thread William Tu
Hi Ilya, Thanks for your review. I will fix them in my next version. On Mon, May 6, 2019 at 5:37 AM Ilya Maximets wrote: > > Hi. Thanks for a new version. > > Quick review inline. > > Best regards, Ilya Maximets. > > On 03.05.2019 22:02, William Tu wrote: > > The patch introduces experimental

Re: [ovs-dev] [PATCHv7] netdev-afxdp: add new netdev type for AF_XDP.

2019-05-06 Thread Ilya Maximets
On 03.05.2019 22:02, William Tu wrote: > +static struct xsk_socket_info * > +xsk_configure(int ifindex, int xdp_queue_id, int xdpmode) > +{ > +struct xsk_socket_info *xsk; > +struct xsk_umem_info *umem; > +void *bufs; > +int ret; > + > +/* umem memory region */ > +ret =

Re: [ovs-dev] [PATCHv7] netdev-afxdp: add new netdev type for AF_XDP.

2019-05-06 Thread Ilya Maximets
Hi. Thanks for a new version. Quick review inline. Best regards, Ilya Maximets. On 03.05.2019 22:02, William Tu wrote: > The patch introduces experimental AF_XDP support for OVS netdev. > AF_XDP, Address Family of the eXpress Data Path, is a new Linux socket type > built upon the eBPF and XDP

[ovs-dev] [PATCHv7] netdev-afxdp: add new netdev type for AF_XDP.

2019-05-03 Thread William Tu
The patch introduces experimental AF_XDP support for OVS netdev. AF_XDP, Address Family of the eXpress Data Path, is a new Linux socket type built upon the eBPF and XDP technology. It is aims to have comparable performance to DPDK but cooperate better with existing kernel's networking stack. An