Hi Abhiram,
Thanks for the patch.
Please see below for some comments.
On Mon, May 9, 2022 at 12:14 PM Abhiram R N wrote:
>
> On Mon, May 09, 2022 at 03:34:47PM +0530, Abhiram R N wrote:
>
> Hi Ihar,
>
>
>
> > On Fri, May 06, 2022 at 07:46:17PM -0400, Ihar Hrachyshka wrote:
> > > Hi Abhiram,
On Mon, May 09, 2022 at 03:34:47PM +0530, Abhiram R N wrote:
Hi Ihar,
> On Fri, May 06, 2022 at 07:46:17PM -0400, Ihar Hrachyshka wrote:
> > Hi Abhiram,
> >
> > thanks for sending the patch.
>
> Thanks for spening time to review it.
>
> >
> > This is *not* a comprehensive review. This is
On Fri, May 06, 2022 at 07:46:17PM -0400, Ihar Hrachyshka wrote:
> Hi Abhiram,
>
> thanks for sending the patch.
Thanks for spening time to review it.
>
> This is *not* a comprehensive review. This is an attempt to clarify
> the scope of the feature, its potential crossover with other pending
Hi Abhiram,
thanks for sending the patch.
This is *not* a comprehensive review. This is an attempt to clarify
the scope of the feature, its potential crossover with other pending
work, and other high level comments.
API:
1) The proposal more or less directly maps the new OVN mirrors to OVS
Bleep bloop. Greetings Abhiram R N, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
#1059 FILE: utilities/ovn-nbctl.c:275:
Added changes in ovn-nbctl, ovn-sbctl, northd and in ovn-controller.
While Mirror creation just creates the mirror, the lsp-attach-mirror
triggers the sequence to create Mirror in OVS DB on compute node.
OVS already supports Port Mirroring.
Note: This is targetted to mirror to destinations
