Re: [ovs-dev] [RFC PATCH] lib/ovs-thread: Expand stack when more memory is available.

2022-10-20 Thread Eelco Chaudron
On 20 Oct 2022, at 16:34, Ilya Maximets wrote: > On 10/20/22 00:13, Mike Pattrick wrote: >> On Wed, Oct 19, 2022 at 12:27 PM Ilya Maximets wrote: >>> >>> On 10/19/22 15:48, Mike Pattrick wrote: On Wed, Oct 19, 2022 at 9:30 AM Flavio Leitner wrote: > > > Hi Mike, > > T

Re: [ovs-dev] [RFC PATCH] lib/ovs-thread: Expand stack when more memory is available.

2022-10-20 Thread Ilya Maximets
On 10/20/22 00:13, Mike Pattrick wrote: > On Wed, Oct 19, 2022 at 12:27 PM Ilya Maximets wrote: >> >> On 10/19/22 15:48, Mike Pattrick wrote: >>> On Wed, Oct 19, 2022 at 9:30 AM Flavio Leitner wrote: Hi Mike, Thanks for the patch. Does this patch need to change

Re: [ovs-dev] [RFC PATCH] lib/ovs-thread: Expand stack when more memory is available.

2022-10-19 Thread Mike Pattrick
On Wed, Oct 19, 2022 at 12:27 PM Ilya Maximets wrote: > > On 10/19/22 15:48, Mike Pattrick wrote: > > On Wed, Oct 19, 2022 at 9:30 AM Flavio Leitner wrote: > >> > >> > >> Hi Mike, > >> > >> Thanks for the patch. > >> > >> Does this patch need to change this line too? > >> https://github.com/openv

Re: [ovs-dev] [RFC PATCH] lib/ovs-thread: Expand stack when more memory is available.

2022-10-19 Thread Ilya Maximets
On 10/19/22 15:48, Mike Pattrick wrote: > On Wed, Oct 19, 2022 at 9:30 AM Flavio Leitner wrote: >> >> >> Hi Mike, >> >> Thanks for the patch. >> >> Does this patch need to change this line too? >> https://github.com/openvswitch/ovs/blob/31db0e043119cf597d720d94f70ec19cf5b8b7d4/rhel/usr_lib_systemd

Re: [ovs-dev] [RFC PATCH] lib/ovs-thread: Expand stack when more memory is available.

2022-10-19 Thread Eelco Chaudron
On 19 Oct 2022, at 15:01, Mike Pattrick wrote: > Previously the minimum thread stack size was always set to 512 kB to > help accomidate smaller OpenWRT based systems. Often these devices > don't have a lot of total system memory, so such a limit makes sense. > > The default under x86-64 linux i

Re: [ovs-dev] [RFC PATCH] lib/ovs-thread: Expand stack when more memory is available.

2022-10-19 Thread Flavio Leitner
On Wed, Oct 19, 2022 at 09:48:18AM -0400, Mike Pattrick wrote: > On Wed, Oct 19, 2022 at 9:30 AM Flavio Leitner wrote: > > > > > > Hi Mike, > > > > Thanks for the patch. > > > > Does this patch need to change this line too? > > https://github.com/openvswitch/ovs/blob/31db0e043119cf597d720d94f70ec1

Re: [ovs-dev] [RFC PATCH] lib/ovs-thread: Expand stack when more memory is available.

2022-10-19 Thread Mike Pattrick
On Wed, Oct 19, 2022 at 9:30 AM Flavio Leitner wrote: > > > Hi Mike, > > Thanks for the patch. > > Does this patch need to change this line too? > https://github.com/openvswitch/ovs/blob/31db0e043119cf597d720d94f70ec19cf5b8b7d4/rhel/usr_lib_systemd_system_ovs-vswitchd.service.in#L18 > > > Wouldn't

Re: [ovs-dev] [RFC PATCH] lib/ovs-thread: Expand stack when more memory is available.

2022-10-19 Thread Flavio Leitner
Hi Mike, Thanks for the patch. Does this patch need to change this line too? https://github.com/openvswitch/ovs/blob/31db0e043119cf597d720d94f70ec19cf5b8b7d4/rhel/usr_lib_systemd_system_ovs-vswitchd.service.in#L18 Wouldn't it be better to have a config option that we can change at runtime? Or

[ovs-dev] [RFC PATCH] lib/ovs-thread: Expand stack when more memory is available.

2022-10-19 Thread Mike Pattrick
Previously the minimum thread stack size was always set to 512 kB to help accomidate smaller OpenWRT based systems. Often these devices don't have a lot of total system memory, so such a limit makes sense. The default under x86-64 linux is 2MB, this limit is not always enough to reach the recursio