Re: [ovs-dev] [RFC v3 1/5] datapath: Add a new action check_pkt_len

Hi Ben and Greg, Please see one comment below inline Thanks Numan On Tue, Feb 12, 2019 at 7:57 AM Ben Pfaff wrote: > Greg, I recommend that you take a look at this one. > > (More commentary below.) > > On Thu, Jan 10, 2019 at 11:29:48PM +0530, nusid...@redhat.com wrote: > > From: Numan

Re: [ovs-dev] [RFC v3 1/5] datapath: Add a new action check_pkt_len

On 2/19/2019 1:15 AM, Numan Siddique wrote: Hi Greg, Please see one comment below Thanks Numan On Thu, Feb 14, 2019 at 6:42 AM Numan Siddique > wrote: On Thu, Feb 14, 2019, 2:58 AM Gregory Rose mailto:gvrose8...@gmail.com>> wrote: Norman,

Re: [ovs-dev] [RFC v3 1/5] datapath: Add a new action check_pkt_len

Hi Greg, Please see one comment below Thanks Numan On Thu, Feb 14, 2019 at 6:42 AM Numan Siddique wrote: > > > On Thu, Feb 14, 2019, 2:58 AM Gregory Rose wrote: > >> Norman, >> >> I couldn't find your original email to reply to so I just copied in your >> patch below. My comments are

Re: [ovs-dev] [RFC v3 1/5] datapath: Add a new action check_pkt_len

On Thu, Feb 14, 2019, 2:58 AM Gregory Rose wrote: > Norman, > > I couldn't find your original email to reply to so I just copied in your > patch below. My comments are preceeded > with ">>>". > > There's some changes I'd like to see and Lorenzo had some good review > comments as well. Thanks

Re: [ovs-dev] [RFC v3 1/5] datapath: Add a new action check_pkt_len

Norman, I couldn't find your original email to reply to so I just copied in your patch below.  My comments are preceeded with ">>>". There's some changes I'd like to see and Lorenzo had some good review comments as well.  Thanks for your work on this! - Greg diff --git

Re: [ovs-dev] [RFC v3 1/5] datapath: Add a new action check_pkt_len

On 2/13/2019 11:03 AM, Ben Pfaff wrote: On Wed, Feb 13, 2019 at 10:53:01AM -0800, Gregory Rose wrote: On 2/12/2019 1:15 PM, Gregory Rose wrote: On 2/11/2019 6:27 PM, Ben Pfaff wrote: Greg, I recommend that you take a look at this one. My apologies but I haven't been feeling well the last

Re: [ovs-dev] [RFC v3 1/5] datapath: Add a new action check_pkt_len

On Wed, Feb 13, 2019 at 10:53:01AM -0800, Gregory Rose wrote: > > On 2/12/2019 1:15 PM, Gregory Rose wrote: > > > > On 2/11/2019 6:27 PM, Ben Pfaff wrote: > > > Greg, I recommend that you take a look at this one. > > > > My apologies but I haven't been feeling well the last few days. I'll > >

Re: [ovs-dev] [RFC v3 1/5] datapath: Add a new action check_pkt_len

On 2/12/2019 1:15 PM, Gregory Rose wrote: On 2/11/2019 6:27 PM, Ben Pfaff wrote: Greg, I recommend that you take a look at this one. My apologies but I haven't been feeling well the last few days. I'll have a look at this one. Thanks, I can't seem to find the actual patch - I went and

Re: [ovs-dev] [RFC v3 1/5] datapath: Add a new action check_pkt_len

On 2/11/2019 6:27 PM, Ben Pfaff wrote: Greg, I recommend that you take a look at this one. My apologies but I haven't been feeling well the last few days. I'll have a look at this one. Thanks, (More commentary below.) On Thu, Jan 10, 2019 at 11:29:48PM +0530, nusid...@redhat.com

Re: [ovs-dev] [RFC v3 1/5] datapath: Add a new action check_pkt_len

Thanks Ben and Lorenzo for the review and comments. Few comments inline. On Tue, Feb 12, 2019 at 7:57 AM Ben Pfaff wrote: > Greg, I recommend that you take a look at this one. > > (More commentary below.) > > On Thu, Jan 10, 2019 at 11:29:48PM +0530, nusid...@redhat.com wrote: > > From: Numan

Re: [ovs-dev] [RFC v3 1/5] datapath: Add a new action check_pkt_len

Greg, I recommend that you take a look at this one. (More commentary below.) On Thu, Jan 10, 2019 at 11:29:48PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > [Please note, this patch is submitted as RFC in ovs-dev ML to > get feedback before submitting to netdev ML] > > This

Re: [ovs-dev] [RFC v3 1/5] datapath: Add a new action check_pkt_len

> From: Numan Siddique > > [Please note, this patch is submitted as RFC in ovs-dev ML to > get feedback before submitting to netdev ML] > > This patch adds a new action which checks the packet length and > executes a set of actions if the packet length is greater than > the specified length or