Re: [ovs-dev] [Suspected-Phishing]Re: [Suspected-Phishing] [PATCH 1/1] dpif-netlink: Warn eth type 0x1234 not offloadable

[Roi Dayan]

On 2019-07-02 2:21 PM, Roi Dayan wrote:
> 
> 
> On 2019-06-30 9:16 AM, Eli Britstein wrote:
>> Ethernet type 0x1234 is used for testing and not being offloadable. For
>> testing offloadable features, warn about using this value.
>>
>> Signed-off-by: Eli Britstein <el...@mellanox.com>
>> ---
>>  lib/dpif-netlink.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c
>> index ba80a0079..327076784 100644
>> --- a/lib/dpif-netlink.c
>> +++ b/lib/dpif-netlink.c
>> @@ -2007,6 +2007,7 @@ parse_flow_put(struct dpif_netlink *dpif, struct 
>> dpif_flow_put *put)
>>  
>>      /* When we try to install a dummy flow from a probed feature. */
>>      if (match.flow.dl_type == htons(0x1234)) {
>> +        VLOG_WARN("eth 0x1234 is special and not offloadable");
>>          return EOPNOTSUPP;
>>      }
>>  
>>
> 
> why a warn is needed?

nm. somehow skipped your commit msg.
did u check by any chance if unit tests won't fail as they need to filter this 
from the log?

> 
> _______________________________________________
> dev mailing list
> d...@openvswitch.org
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.openvswitch.org%2Fmailman%2Flistinfo%2Fovs-dev&amp;data=02%7C01%7Croid%40mellanox.com%7Ce8fb39de2ec84d799be308d6fedfa943%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636976633920052415&amp;sdata=VHoqOa8rylBZNj9q8W3fa4H3xx55NK3qR2tEDvBIeRg%3D&amp;reserved=0
> 
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev