Re: [ovs-dev] [dpdk-howl PATCH v2] netdev-dpdk: Upgrade to dpdk v18.08.0

2018-09-19 Thread Ophir Munk
Hi, Also, please note in file Documentation/topics/dpdk/vhost-user.rst: I did not update "v17.11" in the following link (as there is currently no link to "v18.08"). > Further information can be found in the DPDK documentation > `__

Re: [ovs-dev] [dpdk-howl PATCH v2] netdev-dpdk: Upgrade to dpdk v18.08.0

2018-09-19 Thread Ophir Munk
Hi all, I incorporated all your reviews into v3 patch which was sent to the mailing list: https://patchwork.ozlabs.org/patch/971860/ Regards, Ophir > -Original Message- > From: Stokes, Ian [mailto:ian.sto...@intel.com] > Sent: Wednesday, September 19, 2018 12:55 PM > To: Ophir Munk ;

Re: [ovs-dev] [dpdk-howl PATCH v2] netdev-dpdk: Upgrade to dpdk v18.08.0

2018-09-19 Thread Stokes, Ian
> Hi Sugesh, > I can update documentation. Is it enough to update dpdk.rst.txt only? > If not - can you please send a link to additional files with references to > 17.11 to be updated? > I will wait 1-2 days to get more reviews then will send v3. > Hi Ophir, In terms of functionality I've smoke

Re: [ovs-dev] [dpdk-howl PATCH v2] netdev-dpdk: Upgrade to dpdk v18.08.0

2018-09-17 Thread Eelco Chaudron
Hi Ophir, I did some basic PVP testing root vs non-root and it all seems to work as expected (did not do any performance comparison). I do see compiler warnings about usage of deprecated DPDK functions, I guess these need to be fixed: lib/netdev-dpdk.c: In function 'netdev_dpdk_destruct':

Re: [ovs-dev] [dpdk-howl PATCH v2] netdev-dpdk: Upgrade to dpdk v18.08.0

2018-09-13 Thread Chandran, Sugesh
Regards _Sugesh > >> -2.10.x 17.11.3 > >> +2.10.x 18.08.0 > > > > Hi - on updating versions in docs, this one should not change as the > > released/to be released versions of OVS 2.10.x stick with 17.11.x. We > > can just leave this unmodified for now and add an

Re: [ovs-dev] [dpdk-howl PATCH v2] netdev-dpdk: Upgrade to dpdk v18.08.0

2018-09-13 Thread Ian Stokes
On 9/13/2018 1:57 PM, Kevin Traynor wrote: On 09/13/2018 01:45 PM, Ian Stokes wrote: On 9/13/2018 1:34 PM, Ophir Munk wrote: Hi Sugesh, I can update documentation. Is it enough to update dpdk.rst.txt only? If not - can you please send a link to additional files with references to 17.11 to be

Re: [ovs-dev] [dpdk-howl PATCH v2] netdev-dpdk: Upgrade to dpdk v18.08.0

2018-09-13 Thread Kevin Traynor
On 09/13/2018 01:45 PM, Ian Stokes wrote: > On 9/13/2018 1:34 PM, Ophir Munk wrote: >> Hi Sugesh, >> I can update documentation. Is it enough to update dpdk.rst.txt only? >> If not - can you please send a link to additional files with >> references to 17.11 to be updated? >> I will wait 1-2 days

Re: [ovs-dev] [dpdk-howl PATCH v2] netdev-dpdk: Upgrade to dpdk v18.08.0

2018-09-13 Thread Ian Stokes
On 9/13/2018 1:34 PM, Ophir Munk wrote: Hi Sugesh, I can update documentation. Is it enough to update dpdk.rst.txt only? If not - can you please send a link to additional files with references to 17.11 to be updated? I will wait 1-2 days to get more reviews then will send v3. Hi Ophir, I've

Re: [ovs-dev] [dpdk-howl PATCH v2] netdev-dpdk: Upgrade to dpdk v18.08.0

2018-09-13 Thread Ophir Munk
Hi Sugesh, I can update documentation. Is it enough to update dpdk.rst.txt only? If not - can you please send a link to additional files with references to 17.11 to be updated? I will wait 1-2 days to get more reviews then will send v3. Regards, Ophir > -Original Message- > From:

Re: [ovs-dev] [dpdk-howl PATCH v2] netdev-dpdk: Upgrade to dpdk v18.08.0

2018-09-13 Thread Chandran, Sugesh
Hi Ophir, Also a quick grep show there are number of places in documentation still pointing to DPDK17.11, I guess its worth while to change them as well. This will avoid confusion for people who wanted to use this branch, What do you think? Regards _Sugesh > -Original Message- >

Re: [ovs-dev] [dpdk-howl PATCH v2] netdev-dpdk: Upgrade to dpdk v18.08.0

2018-09-12 Thread Chandran, Sugesh
Hi Ophir, I verified this patch in our test lab and looks fine to me. I have couple of minor comments in the V1 series. Could you please take care of them as well? Regards _Sugesh > -Original Message- > From: Ophir Munk [mailto:ophi...@mellanox.com] > Sent: Tuesday, September 11, 2018

[ovs-dev] [dpdk-howl PATCH v2] netdev-dpdk: Upgrade to dpdk v18.08.0

2018-09-10 Thread Ophir Munk
1. Enable compilation and linkage with dpdk 18.08.0 The following dpdk commits which were introduced after dpdk 17.11.x require OVS updates to accommodate to the dpdk changes. - ce17eddefc20 ("ethdev: introduce Rx queue offloads API") - ab3ce1e0c193 ("ethdev: remove old offload API") -

[ovs-dev] [dpdk-howl PATCH v2] netdev-dpdk: Upgrade to dpdk v18.08.0

2018-09-10 Thread Ophir Munk
1. Enable compilation and linkage with dpdk 18.08.0 The following dpdk commits which were introduced after dpdk 17.11.x require OVS updates to accommodate to the dpdk changes. - ce17eddefc20 ("ethdev: introduce Rx queue offloads API") - ab3ce1e0c193 ("ethdev: remove old offload API") -